[lib] Mark missing users when fetching device lists
ClosedPublic
Actions

Authored by inka on Oct 16 2024, 8:33 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMMe03089ba3f24: [lib] Mark missing users when fetching device lists

Summary

issue: ENG-9631

Test Plan

Tested that when a user is missing a device list the accountMissingStatus is set. Checked that lastChecked is updated with next requests but missingSince stays the same.

checked that if non-empty a device list is returned by identity, accountMissingStatus is removed.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 16 2024, 8:33 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 16 2024, 8:33 AM

inka added a parent revision: D13727: [lib] Reduce users missing from identity.Oct 16 2024, 8:33 AM

inka added a child revision: D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.Oct 16 2024, 8:39 AM

Harbormaster completed remote builds in B32271: Diff 45227.Oct 16 2024, 8:52 AM

inka requested review of this revision.Oct 16 2024, 8:52 AM

tomek accepted this revision.Oct 17 2024, 2:34 AM

This revision is now accepted and ready to land.Oct 17 2024, 2:34 AM

Device list can be empty for a registered user if they log out of all devices

Harbormaster completed remote builds in B32293: Diff 45255.Oct 17 2024, 6:41 AM

Closed by commit rCOMMe03089ba3f24: [lib] Mark missing users when fetching device lists (authored by inka). · Explain WhyOct 21 2024, 6:42 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe03089ba3f24: [lib] Mark missing users when fetching device lists.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-utils.js

20 lines

thread-utils.js

11 lines

Diff 45255

View Options

lib/shared/dm-ops/dm-op-utils.js