[lib] Reduce removePeerUsersActionType in thread reducer
ClosedPublic
Actions

Authored by inka on Oct 17 2024, 4:11 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM3522e8e1d74d: [lib] Reduce removePeerUsersActionType in thread reducer

Summary

issue: ENG-9634
In the thread reducer we want to use generateOpsAndProcessThreadUpdates which reduces delete account updates. In the future removePeerUsersActionType will be fully replaced by an update sent with processDMOpsActionType action. But this is tracked in ENG-4905

Test Plan

Tested by dispatching removePeerUsersActionType action. Tested that the user gets deleted: they get removed from threads, user store and aux user store.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Oct 17 2024, 4:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 17 2024, 4:11 AM

inka edited the test plan for this revision. (Show Details)Oct 17 2024, 4:12 AM

inka added a parent revision: D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.

inka added a child revision: D13741: [lib] Delete users for whom identity didnt return a device list for a long time.Oct 17 2024, 4:22 AM

Harbormaster completed remote builds in B32286: Diff 45244.Oct 17 2024, 4:29 AM

inka requested review of this revision.Oct 17 2024, 4:29 AM

tomek accepted this revision.Mon, Oct 21, 3:23 AM

tomek added inline comments.

lib/reducers/thread-reducer.js
266–267 ↗	(On Diff #45244)	Can we handle this action here?
lib/tunnelbroker/use-peer-to-peer-message-handler.js
154 ↗	(On Diff #45244)	I guess it's fine as is, but does the message contain a timestamp that we can use here?