[keyserver] Fix synchronizing invite links with blobs
ClosedPublic
Actions

Authored by tomek on Oct 22 2024, 7:26 AM.

Details

Reviewers

kamil
angelika

Commits

rCOMM9f827f1f012d: [keyserver] Fix synchronizing invite links with blobs

Summary

We were encoding the hashes twice - once in this method and again in uploadInviteLinkBlob.

https://linear.app/comm/issue/ENG-9715/blobs-with-invite-invite-prefix

Test Plan

Create a new invite link. Rename it by hand. Check the blob service - a blob for the modified link shouldn't exist. Force the script to run - the correct blob should appear.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 22 2024, 7:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 22 2024, 7:26 AM

Fix checking blobs

Harbormaster completed remote builds in B32328: Diff 45317.Oct 22 2024, 7:51 AM

Harbormaster completed remote builds in B32329: Diff 45318.Oct 22 2024, 7:57 AM

tomek requested review of this revision.Oct 22 2024, 7:57 AM

tomek added a child revision: D13768: [keyserver] Delete invalid invite links.Oct 22 2024, 9:15 AM

kamil accepted this revision.Oct 24 2024, 4:58 AM

This revision is now accepted and ready to land.Oct 24 2024, 4:58 AM

Closed by commit rCOMM9f827f1f012d: [keyserver] Fix synchronizing invite links with blobs (authored by tomek). · Explain WhyOct 24 2024, 7:50 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9f827f1f012d: [keyserver] Fix synchronizing invite links with blobs.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

synchronize-invite-links-with-blobs.js

5 lines

Diff 45317

View Options

keyserver/src/utils/synchronize-invite-links-with-blobs.js

[keyserver] Fix synchronizing invite links with blobsClosedPublicActions