Page MenuHomePhabricator
Differential D13745

[web] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar
ClosedPublic
Actions

Authored by varun on Oct 17 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:17 AM
Unknown Object (File)
Wed, Nov 20, 8:16 AM
Unknown Object (File)
Wed, Nov 20, 8:16 AM
Unknown Object (File)
Sun, Nov 17, 5:19 AM
Unknown Object (File)
Sun, Nov 10, 4:43 PM
Unknown Object (File)
Thu, Nov 7, 7:34 AM
Unknown Object (File)
Mon, Nov 4, 5:41 PM
Unknown Object (File)
Mon, Nov 4, 4:44 PM
View All 34 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM27b52055b5d7: [web] update ThreadAvatar component to pass farcaster channel ID to…
Summary

Depends on D13744

pass an object containing username/fid or an object containing a farcaster channel ID to useResolvedThreadAvatar

Test Plan

modified threads table in mariadb successfully set thread avatars for all threads in a tagged community to the fc channel image. was able to change child threads to other avatar types

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 17 2024, 5:53 AM
varun held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptOct 17 2024, 5:53 AM
varun added a child revision: D13746: [native] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar.Oct 17 2024, 5:54 AM
Harbormaster completed remote builds in B32291: Diff 45253.Oct 17 2024, 6:20 AM
varun published this revision for review.Oct 17 2024, 9:01 PM
varun added inline comments.
web/avatars/thread-avatar.react.js
67–72 ↗(On Diff #45253)

I think if there is a displayUserIDForThread and a communityInfo?.farcasterChannelID, the former should supersede the latter

varun added inline comments.Oct 18 2024, 9:51 AM
web/avatars/thread-avatar.react.js
37 ↗(On Diff #45253)

btw, after re-reading the getCommunity code, it seems like it gives us what we want. we were concerned that it would only work for child threads in a community but it returns the community for the community root thread as well, I believe. tested this, too

ashoat accepted this revision.Oct 20 2024, 11:36 AM
ashoat added inline comments.
web/avatars/thread-avatar.react.js
37 ↗(On Diff #45253)

I think I got confused because its input is named parentThreadInfo. Should that just be renamed to threadInfo?

67–72 ↗(On Diff #45253)

Left feedback in D13744, but I think it would be better to pass both in

This revision is now accepted and ready to land.Oct 20 2024, 11:36 AM
ashoat mentioned this in D13746: [native] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar.Oct 20 2024, 11:38 AM
varun updated this revision to Diff 45324.Oct 22 2024, 4:05 PM

rebase

varun mentioned this in D13769: [lib] rename parentThreadInfo -> threadInfo in getCommunity.Oct 22 2024, 4:12 PM
varun added inline comments.Oct 22 2024, 4:13 PM
web/avatars/thread-avatar.react.js
37 ↗(On Diff #45253)

D13769

Harbormaster completed remote builds in B32335: Diff 45324.Oct 22 2024, 4:26 PM
Closed by commit rCOMM27b52055b5d7: [web] update ThreadAvatar component to pass farcaster channel ID to… (authored by varun). · Explain WhyTue, Oct 22, 9:51 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM27b52055b5d7: [web] update ThreadAvatar component to pass farcaster channel ID to….
varun mentioned this in rCOMMa6d3fc46c070: [lib] rename parentThreadInfo -> threadInfo in getCommunity.

Revision Contents
Changeset List

PathSize
web/
avatars/
13 lines

Diff 45324

View Options

web/avatars/thread-avatar.react.js

Loading...