[web] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar
ClosedPublic
Actions

Authored by varun on Oct 17 2024, 5:53 AM.

Details

Reviewers

ashoat

Commits

rCOMM27b52055b5d7: [web] update ThreadAvatar component to pass farcaster channel ID to…

Summary

Depends on D13744

pass an object containing username/fid or an object containing a farcaster channel ID to useResolvedThreadAvatar

Test Plan

modified threads table in mariadb successfully set thread avatars for all threads in a tagged community to the fc channel image. was able to change child threads to other avatar types

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 17 2024, 5:53 AM

varun held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptOct 17 2024, 5:53 AM

varun added a child revision: D13746: [native] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar.Oct 17 2024, 5:54 AM

Harbormaster completed remote builds in B32291: Diff 45253.Oct 17 2024, 6:20 AM

varun published this revision for review.Oct 17 2024, 9:01 PM

varun added inline comments.

web/avatars/thread-avatar.react.js
67–72 ↗	(On Diff #45253)	I think if there is a `displayUserIDForThread` and a `communityInfo?.farcasterChannelID`, the former should supersede the latter

varun added inline comments.Oct 18 2024, 9:51 AM

web/avatars/thread-avatar.react.js
37 ↗	(On Diff #45253)	btw, after re-reading the `getCommunity` code, it seems like it gives us what we want. we were concerned that it would only work for child threads in a community but it returns the community for the community root thread as well, I believe. tested this, too

ashoat accepted this revision.Oct 20 2024, 11:36 AM

ashoat added inline comments.

web/avatars/thread-avatar.react.js
37 ↗	(On Diff #45253)	I think I got confused because its input is named `parentThreadInfo`. Should that just be renamed to `threadInfo`?
67–72 ↗	(On Diff #45253)	Left feedback in D13744, but I think it would be better to pass both in