keyserver/src/fetchers/thread-fetchers.js
315–316 ↗	(On Diff #45272)	the min native and web versions were set to the same versions as fetchKnownUserInfos Wait, is this right? I'm a bit confused... won't clients need the changes in the preceding diffs in the stack in order to be able to render thread avatars set to `{ type: 'farcaster' }`? If not, can you: Explain what makes the referenced `fetchKnownUserInfos` versions important (code link would be helpful) Explain what clients with version 405 and above (but below the next code version) will see (My instinct is that you want `NEXT_CODE_VERSION` here)
lib/shared/thread-utils.js
907–911 ↗	(On Diff #45272)	I think this condition would be more clear if inverted

This revision now requires changes to proceed.Oct 20 2024, 11:43 AM

varun added inline comments.Oct 22 2024, 12:00 PM

keyserver/src/fetchers/thread-fetchers.js
315–316 ↗	(On Diff #45272)	In `fetchKnownUserInfos`, we check the client code version to determine whether the client is aware of the `farcaster` avatar type. https://github.com/CommE2E/comm/blob/4fd312324232d629655075a693683e9a03b38be6/keyserver/src/fetchers/user-fetchers.js#L182 Versions above 405 but below the next code version will have either the before or after of this landed commit, or they will have the changes from this diff stack which include support for farcaster thread avatars in the case of the former, the `defaultAnonymousUserEmojiAvatar` will be returned by the hook. but i'm realizing it would be better to use NEXT_CODE_VERSION here to display a default thread avatar instead... will update this diff

address feedback

Harbormaster completed remote builds in B32333: Diff 45322.Oct 22 2024, 12:41 PM

Versions above 405 but below the next code version will have either the before or after of this landed commit, or they will have the changes from this diff stack which include support for farcaster thread avatars

Hard to follow what you're trying to say here, but since you're using NEXT_CODE_VERSION now I'll accept

This revision is now accepted and ready to land.Oct 22 2024, 1:32 PM

Closed by commit rCOMM87a7adb38c84: [lib] modify rawThreadInfoFromServerThreadInfo to return default avatar to old… (authored by varun). · Explain WhyOct 22 2024, 9:52 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM87a7adb38c84: [lib] modify rawThreadInfoFromServerThreadInfo to return default avatar to old….