Paths

Table of Contentst

set farcaster avatar and channel description in db during createOrUpdateFarcasterChannelTag
Needs RevisionPublic
Actions

Authored by varun on Wed, Oct 23, 10:47 AM.

Details

Reviewers

Summary

when a community is tagged with a farcaster channel, we want to display the farcaster channel avatar and description (without overwriting a pre-existing description or avatar)

Test Plan

Tested in conjunction with next diff

name

avatar

description

Created community

84426

Oct23

NULL

Tagged community with spam channel. NULL description was replaced with description from neynar. (also confirmed that avatar and description were updated on client)

84426

Oct23

{"type":"farcaster"}

Dedicated channel for everything $SPAM

Removed tag. avatar was reset to NULL. description remained

84426

Oct23

NULL

Dedicated channel for everything $SPAM

Removed description from native app. It was set to an empty string

84426

Oct23

NULL

Added a new description from app.

84426

Oct23

NULL

Asdf

Tagged community with a different channel. Avatar changed but description remained the same.

84426

Oct23

{"type":"farcaster"}

Asdf

Removed tag

84426

Oct23

NULL

Asdf

Removed description

84426

Oct23

NULL

Tagged community with a different channel. empty string description was replaced with description from neynar

84426

Oct23

{"type":"farcaster"}

your musings, thoughts & dreams; welcome here

Removed tag and set a custom emoji avatar

84426

Oct23

{"type":"emoji","emoji":"?","color":"57697f"}

your musings, thoughts & dreams; welcome here

Added and removed a new tag, avatar was not overwritten

84426

Oct23

{"type":"emoji","emoji":"?","color":"57697f"}

your musings, thoughts & dreams; welcome here

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Wed, Oct 23, 10:47 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 23, 10:47 AM

varun added a child revision: D13779: reset avatar when deleteFarcasterChannelTag is called.Wed, Oct 23, 10:50 AM

varun edited the test plan for this revision. (Show Details)Wed, Oct 23, 10:54 AM

planning changes to rethink this a little

varun planned changes to this revision.Wed, Oct 23, 11:01 AM

varun added inline comments.

keyserver/src/creators/farcaster-channel-tag-creator.js
114–125 ↗	(On Diff #45351)	instead of doing this in the transaction, we should just do it in the background and use the `updateThread` function

Harbormaster completed remote builds in B32349: Diff 45351.Wed, Oct 23, 11:08 AM

use updateThread and modify the thread in the background. doing this lets us display robotext indicating what has changed

improve spacing

ashoat requested changes to this revision.Wed, Oct 23, 7:10 PM

ashoat added inline comments.

keyserver/src/creators/farcaster-channel-tag-creator.js
149–152	I would do this
160–161	Won't this crash if we fail to find `request.commCommunityID`? How about this
174	We can't do it in the background because the result of `updateThread` should be returned to the client and handled in reducers