[lib] reduce thread updates from createOrUpdateFarcasterChannelTag and deleteFarcasterChannelTag
Needs RevisionPublic
Actions

Authored by varun on Thu, Oct 24, 12:37 PM.

Details

Reviewers

ashoat

Summary

Depends on D13779

Test Plan

tested setting and unsetting community tags from a client running an older code version and it worked as expected -- no crashes, communities and threads tables updated on keyserver. eventually the state check mechanism synced the client threads with the keyserver

tested the same thing on a new client that can receive the thread changes directly and confirmed that the actions were reduced correctly and the redux state thread info looked right

Diff Detail

Repository

rCOMM Comm

Branch

farcaster-thread-avatars (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Thu, Oct 24, 12:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Oct 24, 12:37 PM

remove unnecessary import

Harbormaster failed remote builds in B32370: Diff 45381!Thu, Oct 24, 12:51 PM

Harbormaster completed remote builds in B32371: Diff 45382.Thu, Oct 24, 1:07 PM

varun requested review of this revision.Thu, Oct 24, 1:07 PM

I looked at the type of ChangeThreadSettingsResult. It has two properties, one of which is newMessageInfos.

It looks like some of the other action types (eg. deleteCommunityRoleActionTypes.success) aren't reduced in message-reducer.js either. Is there a specific reason we aren't reducing the messages here?

lib/reducers/thread-reducer.js
275–281	Don't think we need this after the type updates I suggest in prior diffs

This revision now requires changes to proceed.Thu, Oct 24, 2:51 PM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-reducer.js

15 lines

Diff 45382

View Options

lib/reducers/thread-reducer.js

[lib] reduce thread updates from createOrUpdateFarcasterChannelTag and deleteFarcasterChannelTagNeeds RevisionPublicActions