Depends on D13779
Details
Details
tested setting and unsetting community tags from a client running an older code version and it worked as expected -- no crashes, communities and threads tables updated on keyserver. eventually the state check mechanism synced the client threads with the keyserver
tested the same thing on a new client that can receive the thread changes directly and confirmed that the actions were reduced correctly and the redux state thread info looked right
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I looked at the type of ChangeThreadSettingsResult. It has two properties, one of which is newMessageInfos.
It looks like some of the other action types (eg. deleteCommunityRoleActionTypes.success) aren't reduced in message-reducer.js either. Is there a specific reason we aren't reducing the messages here?
| lib/reducers/thread-reducer.js | ||
|---|---|---|
| 275–281 ↗ | (On Diff #45382) | Don't think we need this after the type updates I suggest in prior diffs |