[lib] Close tunnelbroker socket when app is in background
ClosedPublic
Actions

Authored by angelika on Thu, Oct 24, 12:25 PM.

Details

Reviewers

tomek
kamil

Commits

rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background

Summary

This diff closes tunnelbroker socket when app goes to background in order to prevent messages from decrypting twice and weird socket state.

https://linear.app/comm/issue/ENG-9741/tunnelbroker-socket-onmessage-is-triggered-before-re-opening-socket

Test Plan

Run the app
Put the app in the background
Send some DMs to the app
Bring the app to the foreground
Observe in logs that the socket is closed after going to the background and verify that no message is received before closing the socket

Diff Detail

Repository

rCOMM Comm

Branch

graszka22/ENG-9741

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Oct 24, 12:25 PM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Oct 24, 12:25 PM

Harbormaster completed remote builds in B32367: Diff 45377.Thu, Oct 24, 12:44 PM

angelika requested review of this revision.Thu, Oct 24, 12:44 PM

kamil accepted this revision.Tue, Oct 29, 6:04 AM

This revision is now accepted and ready to land.Tue, Oct 29, 6:04 AM

Closed by commit rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background (authored by angelika). · Explain WhyTue, Oct 29, 3:03 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

tunnelbroker-context.js

9 lines

Diff 45377

View Options

lib/tunnelbroker/tunnelbroker-context.js

[lib] Close tunnelbroker socket when app is in backgroundClosedPublicActions