[keyserver] add know_of permission if viewer.isScriptViewer
AbandonedPublic
Actions

Authored by varun on Thu, Oct 31, 10:46 PM.

Tags

None

Referenced Files

	F3351189: D13853.diff
	Sat, Nov 23, 12:24 AM

	Unknown Object (File)
	Wed, Nov 20, 6:56 AM

	Unknown Object (File)
	Sun, Nov 17, 4:41 PM

	Unknown Object (File)
	Sun, Nov 17, 4:40 PM

	Unknown Object (File)
	Sun, Nov 17, 11:45 AM

	Unknown Object (File)
	Thu, Nov 14, 10:14 AM

	Unknown Object (File)
	Sun, Nov 10, 11:29 PM

	Unknown Object (File)
	Sun, Nov 10, 12:53 PM

View All 18 Files

Subscribers

ashoat

tomek

Details

Reviewers

ashoat

Summary

we don't want to filter out threads here when the know_of permission is missing for a script viewer

Depends on D13852

Test Plan

check all current callers to make sure none of them are script viewers
called fetchThreadInfos and got back threadInfos for all the thread IDs provided. prior to this diff, most of the threads were being filtered out due to lack of permissions

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Thu, Oct 31, 10:46 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 31, 10:46 PM

varun added a child revision: D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.Thu, Oct 31, 10:48 PM

Harbormaster completed remote builds in B32505: Diff 45569.Thu, Oct 31, 11:04 PM

varun requested review of this revision.Thu, Oct 31, 11:04 PM

varun planned changes to this revision.Thu, Oct 31, 11:11 PM

varun added a reviewer: ashoat.

This is a hacky solution. I don't think it's a good approach

changing approach

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

2 lines

lib/

shared/

thread-utils.js

11 lines

Diff 45569

View Options

keyserver/src/fetchers/thread-fetchers.js