Page MenuHomePhabricator

[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
ClosedPublic

Authored by varun on Thu, Oct 31, 10:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:15 PM
Unknown Object (File)
Sun, Nov 17, 4:41 PM
Unknown Object (File)
Fri, Nov 15, 2:54 AM
Unknown Object (File)
Thu, Nov 14, 9:00 PM
Unknown Object (File)
Thu, Nov 14, 7:03 PM
Unknown Object (File)
Mon, Nov 11, 3:47 AM
Unknown Object (File)
Sat, Nov 9, 2:05 AM
Unknown Object (File)
Fri, Nov 8, 11:18 PM
Subscribers

Details

Summary

Depends on D13853

we return threadInfos here so that we can populate the community directory on clients using the ThreadList component

Test Plan

tested in next diff by calling fetchAllCommunityInfosWithNames and getting a working modal with the ThreadList correctly populated

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun published this revision for review.Thu, Oct 31, 11:11 PM
varun planned changes to this revision.
ashoat requested changes to this revision.Fri, Nov 1, 8:37 AM
ashoat added inline comments.
lib/types/community-types.js
50 ↗(On Diff #45570)

Should this be narrowed? It doesn't appear possible for the server to return undefined

58 ↗(On Diff #45570)

I might be missing something, but this validator appears to only be used on the client. Why are you using mixedRawThreadInfoValidator?

keyserver/src/fetchers/community-fetchers.js
103 ↗(On Diff #45892)

I had to add an explicit type here because flow was confused by result being any-typed

This revision is now accepted and ready to land.Wed, Nov 20, 4:15 AM