Paths

Table of Contentst

Differential D13854

[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
ClosedPublic
Actions

Authored by varun on Nov 1 2024, 5:48 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames

Summary

Depends on D13853

we return threadInfos here so that we can populate the community directory on clients using the ThreadList component

Test Plan

tested in next diff by calling fetchAllCommunityInfosWithNames and getting a working modal with the ThreadList correctly populated

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Nov 1 2024, 5:48 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 1 2024, 5:48 AM

varun added a child revision: D13493: [native] scaffolding for CommunityJoinerModal.Nov 1 2024, 5:49 AM

varun published this revision for review.Nov 1 2024, 6:11 AM

varun planned changes to this revision.

Harbormaster completed remote builds in B32506: Diff 45570.Nov 1 2024, 6:12 AM

ashoat requested changes to this revision.Nov 1 2024, 3:37 PM

ashoat added inline comments.

lib/types/community-types.js
50 ↗	(On Diff #45570)	Should this be narrowed? It doesn't appear possible for the server to return `undefined`
58 ↗	(On Diff #45570)	I might be missing something, but this validator appears to only be used on the client. Why are you using `mixedRawThreadInfoValidator`?

address feedback

varun added inline comments.Nov 20 2024, 5:27 AM

keyserver/src/fetchers/community-fetchers.js
103	I had to add an explicit type here because flow was confused by `result` being any-typed

Harbormaster completed remote builds in B32720: Diff 45892.Nov 20 2024, 11:30 AM

ashoat accepted this revision.Nov 20 2024, 12:15 PM

This revision is now accepted and ready to land.Nov 20 2024, 12:15 PM

Closed by commit rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames. · Explain WhyNov 20 2024, 1:20 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

community-fetchers.js

26 lines

responders/

community-responders.js

7 lines

scripts/

delete-all-fc-channel-tags.js

3 lines

lib/

actions/

community-actions.js

4 lines

types/

community-types.js

25 lines

4 lines

validators/

community-validators.js

8 lines

Diff 45892

keyserver/src/fetchers/community-fetchers.js

Loading...

keyserver/src/responders/community-responders.js

Loading...

keyserver/src/scripts/delete-all-fc-channel-tags.js

Loading...

lib/actions/community-actions.js

Loading...

lib/types/community-types.js

Loading...

lib/types/redux-types.js

Loading...

lib/types/validators/community-validators.js

Loading...