Page MenuHomePhabricator
Differential D13861

[lib] Refactor threads queue in DMOpsQueueHandler
ClosedPublic
Actions

Authored by angelika on Mon, Nov 4, 6:57 AM.
Tags
None
Referenced Files
F3168825: D13861.id45583.diff
Thu, Nov 7, 8:39 AM
F3168822: D13861.id45620.diff
Thu, Nov 7, 8:39 AM
F3168798: D13861.id45601.diff
Thu, Nov 7, 8:31 AM
F3168555: D13861.diff
Thu, Nov 7, 6:41 AM
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler
Summary

https://linear.app/comm/issue/ENG-9808/consider-modifying-the-queues-logic-to-be-more-resilient

Depends on D13860

Test Plan

Add entities to the threads queue by calling processDMOps from useProcessDMOperation and verify entities are processed.

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-9808
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Mon, Nov 4, 6:57 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Nov 4, 6:57 AM
Harbormaster completed remote builds in B32517: Diff 45583.Mon, Nov 4, 7:20 AM
angelika requested review of this revision.Mon, Nov 4, 7:20 AM
tomek accepted this revision.Mon, Nov 4, 7:27 AM
tomek added inline comments.
lib/shared/dm-ops/dm-ops-queue-handler.react.js
71

This could be defined closer to the effect.

This revision is now accepted and ready to land.Mon, Nov 4, 7:27 AM
angelika updated this revision to Diff 45601.Tue, Nov 5, 4:08 AM

Review changes

Harbormaster completed remote builds in B32533: Diff 45601.Tue, Nov 5, 4:25 AM
Closed by commit rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler (authored by angelika). · Explain WhyTue, Nov 5, 9:23 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
19 lines

Diff 45583

View Options

lib/shared/dm-ops/dm-ops-queue-handler.react.js

Loading...