[keyserver] change channel text from channel name to slash channel id
ClosedPublic
Actions

Authored by will on Mon, Nov 4, 12:56 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM6cee524642a6: [keyserver] change channel text from channel name to slash channel id

Summary

Addresses https://linear.app/comm/issue/ENG-9847/use-slash-for-channel-instead-of-channel-name-in-sidebar-source.

Replace the "in channel <channel name>" text in the sidebar source message
with "in channel /<channel id>"

Test Plan

Tested with local keyserver and native app running on iOS simulator. Confirmed text appeared as in channel /comm in sidebar source message

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Mon, Nov 4, 12:56 PM

Herald added a subscriber: tomek. · View Herald TranscriptMon, Nov 4, 12:56 PM

will added a child revision: D13866: [keyserver] replace sidebar source message quotes with markdown quotes.Mon, Nov 4, 1:04 PM

Harbormaster completed remote builds in B32523: Diff 45589.Mon, Nov 4, 1:15 PM

will requested review of this revision.Mon, Nov 4, 1:15 PM

ashoat accepted this revision.Mon, Nov 4, 2:04 PM

This revision is now accepted and ready to land.Mon, Nov 4, 2:04 PM

Can you link the Linear task(s) you're addressing? Please always link in both directions (Linear to Phabricator, Phabricator to Linear)

will edited the summary of this revision. (Show Details)Mon, Nov 4, 2:07 PM

Closed by commit rCOMM6cee524642a6: [keyserver] change channel text from channel name to slash channel id (authored by will). · Explain WhyMon, Nov 4, 2:24 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM6cee524642a6: [keyserver] change channel text from channel name to slash channel id.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

farcaster-webhook-responders.js

8 lines

Diff 45589

View Options

keyserver/src/responders/farcaster-webhook-responders.js

[keyserver] change channel text from channel name to slash channel idClosedPublicActions