Page MenuHomePhabricator

[keyserver] replace sidebar source message quotes with markdown quotes
ClosedPublic

Authored by will on Mon, Nov 4, 1:04 PM.
Tags
None
Referenced Files
F3378044: D13866.diff
Wed, Nov 27, 8:46 AM
Unknown Object (File)
Sat, Nov 23, 12:02 AM
Unknown Object (File)
Thu, Nov 21, 1:07 PM
Unknown Object (File)
Thu, Nov 21, 9:01 AM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 1:34 AM
Unknown Object (File)
Tue, Nov 19, 7:49 PM
Unknown Object (File)
Tue, Nov 19, 3:58 PM
Subscribers

Details

Summary

Addresses https://linear.app/comm/issue/ENG-9848/replace-quotes-with-markdown-quotes-in-sidebar-soucre-message and https://linear.app/comm/issue/ENG-9846/move-in-channel-channel-earlier-in-sidebar-source-message

In this diff, we replace the usage of quotations surrounding the cast text and replace it with markdown quotes by prepending > to each line of the original cast text.

The source message ordering is also rearranged with the channel text now accompanying the "author said" text which is then followed by the cast text.

Depends on D13865

Test Plan

Tested by running local keyserver and triggering a sidebar creation with a webhook event. Confirmed that the sidebar source message appeared as expected.

image.png (1×666 px, 258 KB)

Diff Detail

Repository
rCOMM Comm
Branch
farcaster_bot_followups
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Mon, Nov 4, 1:25 PM
This revision is now accepted and ready to land.Mon, Nov 4, 2:04 PM

Can you link the Linear task(s) you're addressing? Please always link in both directions (Linear to Phabricator, Phabricator to Linear)