Page MenuHomePhabricator

[native] Fix incorrectly set verticalBounds in UserProfileAvatar
ClosedPublic

Authored by ashoat on Mon, Nov 4, 1:54 PM.
Tags
None
Referenced Files
F3333357: D13869.diff
Thu, Nov 21, 4:07 AM
F3329623: D13869.id45593.diff
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 6:20 AM
Unknown Object (File)
Wed, Nov 20, 1:21 AM
Unknown Object (File)
Mon, Nov 18, 11:50 AM
Unknown Object (File)
Sun, Nov 17, 12:49 PM
Unknown Object (File)
Sat, Nov 16, 2:00 PM
Unknown Object (File)
Fri, Nov 15, 6:14 AM
Subscribers

Details

Summary

verticalBounds of FullScreenViewModal are using to establish a border that will "cut off" part of the image as it animates back.

In the chat view, we use to prevent the animating image from appearing over the tab bar and the header.

In his initial implementation of UserProfileAvatar, Ginsu seems to have set verticalBounds based on an uninformed guess as to its function.

We don't have any requirements for the profile bottom sheet to have a border that cuts off the image as it animates back, since the bottom sheet appears above (over) navigational elements such as the tab bar and the header.

As such, we can effectively disable verticalBounds by setting it to be the full screen.

This fixes a visual issue where part of the user avatar gets cut off when animating back.

Depends on D13868

Test Plan

I confirmed the visual glitch was gone

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage