Page MenuHomePhabricator

[native] Get rid of userProfileBottomPadding
ClosedPublic

Authored by ashoat on Mon, Nov 4, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:55 AM
Unknown Object (File)
Thu, Nov 21, 1:24 PM
Unknown Object (File)
Thu, Nov 21, 7:57 AM
Unknown Object (File)
Tue, Nov 19, 8:54 PM
Unknown Object (File)
Tue, Nov 19, 9:53 AM
Unknown Object (File)
Mon, Nov 18, 3:03 AM
Unknown Object (File)
Sun, Nov 17, 12:06 PM
Unknown Object (File)
Sun, Nov 17, 4:20 AM
Subscribers

Details

Summary

This padding was hardcoded by Ginsu to add additional space at the bottom of the BottomSheet. It is obviated by my work to consider BottomSheetHandle when setting snapPoints.

This diff reduces the padding somewhat, to be consistent with the rest of our BottomSheets.

Depends on D13869

Test Plan

In combination with the rest of the stack, I tested each individual use of our BottomSheet component to make sure that the bottom padding was reasonable. In most cases it was unchanged; in other cases, it was changed to be more consistent with the other BottomSheets in our codebase. In all cases, there was enough padding for the "home pill" at the bottom of the screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage