Page MenuHomePhabricator
Differential D13866

[keyserver] replace sidebar source message quotes with markdown quotes
ClosedPublic
Actions

Authored by will on Mon, Nov 4, 1:04 PM.
Tags
None
Referenced Files
F3350916: D13866.diff
Sat, Nov 23, 12:02 AM
Unknown Object (File)
Thu, Nov 21, 1:07 PM
Unknown Object (File)
Thu, Nov 21, 9:01 AM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 1:34 AM
Unknown Object (File)
Tue, Nov 19, 7:49 PM
Unknown Object (File)
Tue, Nov 19, 3:58 PM
Unknown Object (File)
Mon, Nov 18, 4:08 PM
View All 24 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMbae9f43c5bb6: [keyserver] replace sidebar source message quotes with markdown quotes
Summary

Addresses https://linear.app/comm/issue/ENG-9848/replace-quotes-with-markdown-quotes-in-sidebar-soucre-message and https://linear.app/comm/issue/ENG-9846/move-in-channel-channel-earlier-in-sidebar-source-message

In this diff, we replace the usage of quotations surrounding the cast text and replace it with markdown quotes by prepending > to each line of the original cast text.

The source message ordering is also rearranged with the channel text now accompanying the "author said" text which is then followed by the cast text.

Depends on D13865

Test Plan

Tested by running local keyserver and triggering a sidebar creation with a webhook event. Confirmed that the sidebar source message appeared as expected.

image.png (1×666 px, 258 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Nov 4, 1:04 PM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Nov 4, 1:04 PM
will edited the test plan for this revision. (Show Details)Mon, Nov 4, 1:05 PM
will edited the summary of this revision. (Show Details)Mon, Nov 4, 1:17 PM
Harbormaster completed remote builds in B32524: Diff 45590.Mon, Nov 4, 1:25 PM
will requested review of this revision.Mon, Nov 4, 1:25 PM
ashoat accepted this revision.Mon, Nov 4, 2:04 PM
This revision is now accepted and ready to land.Mon, Nov 4, 2:04 PM
ashoat added a comment.Mon, Nov 4, 2:04 PM

Can you link the Linear task(s) you're addressing? Please always link in both directions (Linear to Phabricator, Phabricator to Linear)

will edited the summary of this revision. (Show Details)Mon, Nov 4, 2:07 PM
Closed by commit rCOMMbae9f43c5bb6: [keyserver] replace sidebar source message quotes with markdown quotes (authored by will). · Explain WhyMon, Nov 4, 2:24 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMbae9f43c5bb6: [keyserver] replace sidebar source message quotes with markdown quotes.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
7 lines

Diff 45597

View Options

keyserver/src/responders/farcaster-webhook-responders.js

Loading...