Page MenuHomePhabricator
Differential D13861

[lib] Refactor threads queue in DMOpsQueueHandler
ClosedPublic
Actions

Authored by angelika on Nov 4 2024, 6:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:24 PM
Unknown Object (File)
Thu, Dec 19, 1:53 AM
Unknown Object (File)
Wed, Dec 18, 11:10 PM
Unknown Object (File)
Wed, Dec 18, 6:55 PM
Unknown Object (File)
Tue, Dec 17, 10:05 PM
Unknown Object (File)
Mon, Dec 16, 12:33 PM
Unknown Object (File)
Fri, Dec 13, 4:34 AM
Unknown Object (File)
Wed, Dec 11, 8:47 AM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler
Summary

https://linear.app/comm/issue/ENG-9808/consider-modifying-the-queues-logic-to-be-more-resilient

Depends on D13860

Test Plan

Add entities to the threads queue by calling processDMOps from useProcessDMOperation and verify entities are processed.

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-9808
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 4 2024, 6:57 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 4 2024, 6:57 AM
Harbormaster completed remote builds in B32517: Diff 45583.Nov 4 2024, 7:20 AM
angelika requested review of this revision.Nov 4 2024, 7:20 AM
tomek accepted this revision.Nov 4 2024, 7:27 AM
tomek added inline comments.
lib/shared/dm-ops/dm-ops-queue-handler.react.js
71 ↗(On Diff #45583)

This could be defined closer to the effect.

This revision is now accepted and ready to land.Nov 4 2024, 7:27 AM
angelika updated this revision to Diff 45601.Nov 5 2024, 4:08 AM

Review changes

Harbormaster completed remote builds in B32533: Diff 45601.Nov 5 2024, 4:25 AM
Closed by commit rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler (authored by angelika). · Explain WhyNov 5 2024, 9:23 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM95b645922329: [lib] Refactor threads queue in DMOpsQueueHandler.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
19 lines

Diff 45601

View Options

lib/shared/dm-ops/dm-ops-queue-handler.react.js

Loading...