Page MenuHomePhabricator
Differential D14021

[web] Don't render ThreadListProvider in CommunityDrawer
ClosedPublic
Actions

Authored by ashoat on Nov 22 2024, 7:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 9:05 AM
Unknown Object (File)
Sun, Apr 6, 8:20 AM
Unknown Object (File)
Wed, Apr 2, 10:44 PM
Unknown Object (File)
Wed, Apr 2, 10:37 PM
Unknown Object (File)
Wed, Apr 2, 8:26 PM
Unknown Object (File)
Wed, Apr 2, 3:26 PM
Unknown Object (File)
Feb 28 2025, 12:41 PM
Unknown Object (File)
Feb 6 2025, 3:51 AM
View All 45 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM88148c4f6631: [web] Don't render ThreadListProvider in CommunityDrawer
Summary

Searched the codebase and couldn't find any use of ThreadListContext within this component tree. It was initially introduced in D6162, but I couldn't find any uses in that stack either.

This is an expensive component to render, so we should avoid rendering it unless necessary.

Test Plan
  1. I did a thorough search for all consumers of ThreadListContext and confirmed that there were none in this component tree.
  2. I tested the web app in my local environment and didn't see any issues.
  3. I tested the web app in a production setting (my personal server at comm.domains, pointed at my production keyserver on AWS) and didn't see any issues.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/threadlistprovider
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Nov 22 2024, 7:09 AM
Harbormaster completed remote builds in B32785: Diff 45972.Nov 22 2024, 7:35 AM
ashoat requested review of this revision.Nov 22 2024, 7:35 AM
tomek accepted this revision.Nov 25 2024, 3:21 AM

I also searched the codebase and didn't see any usage.

This revision is now accepted and ready to land.Nov 25 2024, 3:21 AM
Closed by commit rCOMM88148c4f6631: [web] Don't render ThreadListProvider in CommunityDrawer (authored by ashoat). · Explain WhyNov 25 2024, 5:59 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM88148c4f6631: [web] Don't render ThreadListProvider in CommunityDrawer.

Revision Contents
Changeset List

PathSize
web/
sidebar/
11 lines

Diff 45972

View Options

web/sidebar/community-drawer.react.js

Show All 34 Lines
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { DBOpsHandler } from 'lib/handlers/db-ops-handler.react.js'; import { DBOpsHandler } from 'lib/handlers/db-ops-handler.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js'; import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { MissingRegistrationDataHandler } from './account/registration/missing-registration-data/missing-registration-data-handler.react.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
▲ Show 20 Lines • Show All 242 Lines • ▼ Show 20 Lines navigation = (
<ChatContextProvider> <ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<ChatMentionContextProvider> <ChatMentionContextProvider>
<RootNavigator /> <RootNavigator />
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<MissingRegistrationDataHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines