Page MenuHomePhabricator

[web] Don't render ThreadListProvider in CommunityDrawer
ClosedPublic

Authored by ashoat on Fri, Nov 22, 7:09 AM.
Tags
None
Referenced Files
F3394269: D14021.id46022.diff
Sat, Nov 30, 6:42 PM
F3394071: D14021.id46022.diff
Sat, Nov 30, 5:11 PM
F3391016: D14021.id45972.diff
Sat, Nov 30, 1:57 AM
F3390928: D14021.id.diff
Sat, Nov 30, 1:34 AM
Unknown Object (File)
Fri, Nov 29, 5:50 PM
Unknown Object (File)
Thu, Nov 28, 7:18 PM
Unknown Object (File)
Thu, Nov 28, 5:25 AM
Unknown Object (File)
Wed, Nov 27, 7:37 PM
Subscribers
None

Details

Summary

Searched the codebase and couldn't find any use of ThreadListContext within this component tree. It was initially introduced in D6162, but I couldn't find any uses in that stack either.

This is an expensive component to render, so we should avoid rendering it unless necessary.

Test Plan
  1. I did a thorough search for all consumers of ThreadListContext and confirmed that there were none in this component tree.
  2. I tested the web app in my local environment and didn't see any issues.
  3. I tested the web app in a production setting (my personal server at comm.domains, pointed at my production keyserver on AWS) and didn't see any issues.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also searched the codebase and didn't see any usage.

This revision is now accepted and ready to land.Mon, Nov 25, 3:21 AM