Page MenuHomePhabricator
Differential D14040

[keyserver] Add param to getRetention to customize activity period being checked
ClosedPublic
Actions

Authored by ashoat on Mon, Nov 25, 11:59 AM.
Tags
None
Referenced Files
F3397162: D14040.diff
Sun, Dec 1, 4:14 PM
Unknown Object (File)
Sat, Nov 30, 6:01 AM
Unknown Object (File)
Fri, Nov 29, 1:49 PM
Unknown Object (File)
Tue, Nov 26, 3:34 AM
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM1e8c15c7ef0f: [keyserver] Add param to getRetention to customize activity period being checked
Summary

We want to introduce new metrics that check retention based on usage in the last week rather than usage in the last day. This will be handled in the next diff, but first we want to factor out the param.

Test Plan

Ran it on my personal server and confirmed that a message appeared with the correct metrics

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Nov 25, 11:59 AM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Nov 25, 11:59 AM
ashoat added a child revision: D14041: [keyserver] Add metrics for weekly retention.Mon, Nov 25, 12:00 PM
Harbormaster completed remote builds in B32830: Diff 46040.Mon, Nov 25, 12:37 PM
ashoat requested review of this revision.Mon, Nov 25, 12:37 PM
varun accepted this revision.Mon, Nov 25, 2:02 PM
varun added inline comments.
keyserver/src/cron/metrics.js
78 ↗(On Diff #46040)
100 ↗(On Diff #46040)

shouldn't we rename this variable? maybe xDaysAgo or something

111 ↗(On Diff #46040)

should this param default to 1 to match the function description?

This revision is now accepted and ready to land.Mon, Nov 25, 2:02 PM
varun added inline comments.Mon, Nov 25, 2:04 PM
keyserver/src/cron/metrics.js
111 ↗(On Diff #46040)

actually we probably want to just update the code comment above. specifically the second sentence

ashoat updated this revision to Diff 46044.Mon, Nov 25, 2:23 PM

Feedback

This revision was landed with ongoing or failed builds.Mon, Nov 25, 2:25 PM
Closed by commit rCOMM1e8c15c7ef0f: [keyserver] Add param to getRetention to customize activity period being checked (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1e8c15c7ef0f: [keyserver] Add param to getRetention to customize activity period being checked.
Harbormaster completed remote builds in B32834: Diff 46044.Mon, Nov 25, 2:41 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
cron/
57 lines

Diff 46045

View Options

keyserver/src/cron/metrics.js

Loading...