Differential D14314

[web] Log the QR code to the console
ClosedPublic
Actions

Authored by tomek on Feb 10 2025, 5:40 AM.

Tags

None

Referenced Files

	F4937210: D14314.id46975.diff
	Mon, Mar 17, 11:10 PM

	F4936431: D14314.id46961.diff
	Mon, Mar 17, 9:37 PM

	F4935872: D14314.id46976.diff
	Mon, Mar 17, 8:45 PM

	F4934059: D14314.diff
	Mon, Mar 17, 5:54 PM

	F4932715: D14314.diff
	Mon, Mar 17, 2:53 PM

	F4930790: D14314.diff
	Mon, Mar 17, 9:54 AM

	F4929880: D14314.diff
	Mon, Mar 17, 8:01 AM

	Unknown Object (File)
	Fri, Mar 14, 7:30 AM

View All 52 Files

Subscribers

Details

Reviewers

kamil
bartek

Commits

rCOMM9f63b70cf9e7: [web] Log the QR code to the console

Summary

Using this URL as a deep link should allow logging in using a simulator as a primary device.

https://linear.app/comm/issue/ENG-10168/improve-qr-login-flow-on-dev

Test Plan

Check in the console if the link is displayed.

Diff Detail

Repository

Branch

qr

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Feb 10 2025, 5:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 10 2025, 5:40 AM

tomek added a child revision: D14315: [native] Fix the styling of the QR URL screen on virtual devices.Feb 10 2025, 6:10 AM

Harbormaster completed remote builds in B33429: Diff 46959.Feb 10 2025, 6:18 AM

tomek requested review of this revision.Feb 10 2025, 6:18 AM

kamil accepted this revision.Feb 10 2025, 6:23 AM

This revision is now accepted and ready to land.Feb 10 2025, 6:23 AM

Closed by commit rCOMM9f63b70cf9e7: [web] Log the QR code to the console (authored by tomek). · Explain WhyFeb 10 2025, 9:09 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9f63b70cf9e7: [web] Log the QR code to the console.

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.react.js

6 lines

Diff 46959

web/account/log-in-form.react.js

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines		if (!qrData) {
	return undefined;			return undefined;
	}			}

	const identityDeviceType = platformToIdentityDeviceType[platform];			const identityDeviceType = platformToIdentityDeviceType[platform];

	return qrCodeLinkURL(qrData.aesKey, qrData.deviceID, identityDeviceType);			return qrCodeLinkURL(qrData.aesKey, qrData.deviceID, identityDeviceType);
	}, [platform, qrData]);			}, [platform, qrData]);

				React.useEffect(() => {
				if (qrCodeURL) {
				console.log(`QR Code URL: ${qrCodeURL}`);
				}
				}, [qrCodeURL]);

	const { pushModal, clearModals, popModal } = useModalContext();			const { pushModal, clearModals, popModal } = useModalContext();

	React.useEffect(() => {			React.useEffect(() => {
	return clearModals;			return clearModals;
	}, [clearModals]);			}, [clearModals]);

	const openRecoveryModal = React.useCallback(() => {			const openRecoveryModal = React.useCallback(() => {
	pushModal(			pushModal(
	▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines