Details

Reviewers

tomek
bartek

Commits

rCOMM45ddb4b1a729: [keyserver] deprecate `unpickleOlmSession`

Summary

Fixing issue described in ENG-10144#comment-16a38c06.

Tracked in ENG-10175

unpickleOlmSession was creating olm.Session object, and it was hard to maintain freeing the memory.

Depends on D14324

Test Plan

Notifs from keyserver works

Diff Detail

Repository

rCOMM Comm

Branch

memory-leaks-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 10 2025, 3:54 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 10 2025, 3:54 PM

kamil added a child revision: D14327: [keyserver] update `createPickledOlmSession` to free memory.Feb 10 2025, 4:06 PM

Harbormaster completed remote builds in B33441: Diff 46971.Feb 10 2025, 4:20 PM

kamil published this revision for review.Feb 10 2025, 4:28 PM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Feb 11 2025, 10:56 AM

tomek added inline comments.

keyserver/src/utils/olm-objects.js
68–79	`session.unpickle` takes a key and a session, while `callback` takes the same parameters in the reverse order. Can we make them consistent?

This revision is now accepted and ready to land.Feb 11 2025, 10:56 AM

kamil added inline comments.Feb 12 2025, 2:59 PM

keyserver/src/utils/olm-objects.js
68–79	I'll put a follow-up diff with that change

rebase

Harbormaster completed remote builds in B33486: Diff 47053.Feb 12 2025, 3:30 PM

Closed by commit rCOMM45ddb4b1a729: [keyserver] deprecate `unpickleOlmSession`. · Explain WhyFeb 12 2025, 4:48 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM45ddb4b1a729: [keyserver] deprecate `unpickleOlmSession`.

kamil mentioned this in D14358: [keyserver] remove `picklingKey` from callback in `unpickleSessionAndUseCallback`.Feb 13 2025, 11:30 AM

kamil added inline comments.Feb 13 2025, 11:31 AM

keyserver/src/utils/olm-objects.js
68–79	D14358

kamil mentioned this in rCOMMfc72e96e3bfa: [keyserver] remove `picklingKey` from callback in….Feb 14 2025, 9:35 AM

[keyserver] deprecate `unpickleOlmSession`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46971

keyserver/src/updaters/olm-session-updater.js

keyserver/src/utils/olm-objects.js

keyserver/src/utils/olm-utils.js

[keyserver] deprecate `unpickleOlmSession`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46971

keyserver/src/updaters/olm-session-updater.js

keyserver/src/utils/olm-objects.js

keyserver/src/utils/olm-utils.js

[keyserver] deprecate `unpickleOlmSession`
ClosedPublic
Actions

Revision Contents
Changeset List