Paths

Table of Contentst

-
services/
-
docker-compose.tests.yml
-
identity/src/grpc_services/
-
src/
-
grpc_services/
-
authenticated.rs

[identity] Better handle new flow users in v1 logout
ClosedPublic
Actions

Authored by bartek on Feb 18 2025, 1:51 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout

Summary

Addresses 1 and 2a from ENG-10202.

For v2 flow primary device logout, display an error message
For v1 flow primary device logout, remove backup to future-proof restore flow (make sure it falls back to v1).

Test Plan

Tested on staging

Diff Detail

Repository

rCOMM Comm

Branch

barthap/dev

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Feb 18 2025, 1:51 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 18 2025, 1:51 AM

Harbormaster failed remote builds in B33535: Diff 47136!Feb 18 2025, 2:17 AM

Add backup service url to commtest config

bartek published this revision for review.Feb 18 2025, 6:44 AM

bartek added inline comments.

services/identity/src/grpc_services/authenticated.rs
398–401	This can trigger alarms. Wondering if should lower it to warn.

kamil accepted this revision.Feb 19 2025, 2:34 AM

kamil added inline comments.

services/identity/src/grpc_services/authenticated.rs
398–401	I would leave it as it is - we can lower if needed
1291	should we reuse to reduce code duplication, e.g. `verify_device_on_device_list`?

This revision is now accepted and ready to land.Feb 19 2025, 2:34 AM

bartek added inline comments.Feb 20 2025, 6:19 AM

services/identity/src/grpc_services/authenticated.rs
1291	Yes, good find

Use get_current_device_list helper in other places

Harbormaster completed remote builds in B33555: Diff 47167.Feb 20 2025, 6:38 AM

Closed by commit rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout (authored by bartek). · Explain WhyFeb 20 2025, 6:40 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout.

bartek mentioned this in D14392: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:42 AM

bartek mentioned this in rCOMM24d01125df19: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:54 AM

Revision Contents
Changeset List

Path

Size

services/

docker-compose.tests.yml

1 line

identity/

src/

grpc_services/

authenticated.rs

79 lines

Diff 47143

View Options

services/docker-compose.tests.yml

Show First 20 Lines • Show All 494 Lines • ▼ Show 20 Lines	messageStoreThreads: sqliteQueryExecutor
})),		})),
reports: sqliteQueryExecutor.getAllReports(),		reports: sqliteQueryExecutor.getAllReports(),
users: sqliteQueryExecutor.getAllUsers(),		users: sqliteQueryExecutor.getAllUsers(),
keyservers: sqliteQueryExecutor.getAllKeyservers(),		keyservers: sqliteQueryExecutor.getAllKeyservers(),
communities: sqliteQueryExecutor.getAllCommunities(),		communities: sqliteQueryExecutor.getAllCommunities(),
integrityThreadHashes: sqliteQueryExecutor.getAllIntegrityThreadHashes(),		integrityThreadHashes: sqliteQueryExecutor.getAllIntegrityThreadHashes(),
syncedMetadata: sqliteQueryExecutor.getAllSyncedMetadata(),		syncedMetadata: sqliteQueryExecutor.getAllSyncedMetadata(),
auxUserInfos: sqliteQueryExecutor.getAllAuxUserInfos(),		auxUserInfos: sqliteQueryExecutor.getAllAuxUserInfos(),
		threadActivityEntries: [],
};		};
}		}

export {		export {
processDBStoreOperations,		processDBStoreOperations,
getProcessingStoreOpsExceptionMessage,		getProcessingStoreOpsExceptionMessage,
getClientStoreFromQueryExecutor,		getClientStoreFromQueryExecutor,
};		};