[lib] Handle user_not_found returned by GetKeyserverKeys RPC
ClosedPublic
Actions

Authored by bartek on Feb 27 2025, 7:58 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC

Summary

Address ENG-10261.
Replaced user_not_found with custom error message that doesn't trigger the "Invalid username or password" alert.

Test Plan

Mocked GetKeyserverKeys to always throw new Error('user_not_found')
Before: invalid credentials alert was shown
After: unknown error modal is shown

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Feb 27 2025, 7:58 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2025, 7:58 AM

bartek published this revision for review.Feb 27 2025, 8:30 AM

tomek accepted this revision.Feb 27 2025, 9:00 AM

tomek added inline comments.

lib/keyserver-conn/keyserver-auth.js
158	Should we show a different alert in such a case?

This revision is now accepted and ready to land.Feb 27 2025, 9:00 AM

bartek added inline comments.Feb 28 2025, 12:56 AM

lib/keyserver-conn/keyserver-auth.js
158	This might be worth considering when implementing support for multiple keyservers. Now, this is a case only for authoritative keyserver auth, so I don't think UI changes are necessary.

This revision was landed with ongoing or failed builds.Feb 28 2025, 3:27 AM

Closed by commit rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.

Revision Contents
Changeset List

Path

Size

lib/

keyserver-conn/

keyserver-auth.js

6 lines

Diff 47293

View Options

lib/keyserver-conn/keyserver-auth.js

Show First 20 Lines • Show All 145 Lines • ▼ Show 20 Lines	(inputs: KeyserverAuthInputs) =>
} catch (e) {		} catch (e) {
if (hasBeenCancelled()) {		if (hasBeenCancelled()) {
return;		return;
}		}
console.log(		console.log(
`Error while authenticating to keyserver with id ${keyserverID}`,		`Error while authenticating to keyserver with id ${keyserverID}`,
e,		e,
);		);
		if (getMessageForException(e) === 'user_not_found') {
		// We want to distinguish user_not_found returned by
		// the GetKeyserverKeys RPC from regular user_not_found
		// which means invalid username provided by user.
		throw new Error('keyserver_owner_not_found');
		tomekUnsubmitted Not Done Inline Actions Should we show a different alert in such a case? tomek: Should we show a different alert in such a case?
		bartekAuthorUnsubmitted Done Inline Actions This might be worth considering when implementing support for multiple keyservers. Now, this is a case only for authoritative keyserver auth, so I don't think UI changes are necessary. bartek: This might be worth considering when implementing support for multiple keyservers. Now, this is…
		}
throw e;		throw e;
} finally {		} finally {
if (!hasBeenCancelled()) {		if (!hasBeenCancelled()) {
void (async () => {		void (async () => {
await sleep(AUTH_RETRY_DELAY_MS);		await sleep(AUTH_RETRY_DELAY_MS);
setInProgress(false);		setInProgress(false);
})();		})();
}		}
Show All 39 Lines

[lib] Handle user_not_found returned by GetKeyserverKeys RPCClosedPublicActions