[native] remove `useStaffCanSee` from `BackupHandler`
ClosedPublic
Actions

Authored by kamil on Feb 28 2025, 4:03 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMdf2230754b77: [native] remove `useStaffCanSee` from `BackupHandler`

Summary

Caught by @tomek. useStaffCanSee is basically the same as useIsRestoreFlowEnabled anyway, but because we were not using useIsRestoreFlowEnabled, the migration could still be turned off after release.

This is because this handler was implemented a lot earlier than useIsRestoreFlowEnabled.

Test Plan

useIsRestoreFlowEnabled -> false
Created account, handler is disabled, user is on v1
useIsRestoreFlowEnabled -> true
Migration executed and backup uploaded

Diff Detail

Repository

rCOMM Comm

Branch

update

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 28 2025, 4:03 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 28 2025, 4:03 AM

kamil edited the summary of this revision. (Show Details)Feb 28 2025, 4:04 AM

Harbormaster failed remote builds in B33652: Diff 47305!Feb 28 2025, 4:08 AM

kamil edited the test plan for this revision. (Show Details)Feb 28 2025, 4:12 AM

kamil published this revision for review.Feb 28 2025, 4:14 AM

Harbormaster completed remote builds in B33652: Diff 47305.Feb 28 2025, 4:22 AM

tomek accepted this revision.Feb 28 2025, 5:13 AM

This revision is now accepted and ready to land.Feb 28 2025, 5:13 AM

Closed by commit rCOMMdf2230754b77: [native] remove `useStaffCanSee` from `BackupHandler` (authored by kamil). · Explain WhyFeb 28 2025, 7:25 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdf2230754b77: [native] remove `useStaffCanSee` from `BackupHandler`.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

6 lines

Diff 47305

View Options

native/backup/backup-handler.js

Show All 20 Lines	RUN if [ $(echo $TARGETPLATFORM \| cut -d / -f2) = "arm64" ]; then \
else \		else \
curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"; \		curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"; \
fi		fi
RUN unzip -q awscliv2.zip && ./aws/install \		RUN unzip -q awscliv2.zip && ./aws/install \
&& rm -rf awscliv2.zip aws		&& rm -rf awscliv2.zip aws

WORKDIR /home/root/services/commtest		WORKDIR /home/root/services/commtest

		# Add the Rust target for ARM64 architecture
		RUN rustup target add aarch64-unknown-linux-gnu

# Install cargo lambda		# Install cargo lambda
RUN pip3 install cargo-lambda		RUN pip3 install cargo-lambda

# Install more recent version of protobuf, must be ran as root		# Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh		COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh		RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse		ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse

Show All 15 Lines

[native] remove `useStaffCanSee` from `BackupHandler`ClosedPublicActions