Page MenuHomePhabricator
Differential D14426

[native] Allow useIntentionalSaveMedia to be called with messageInfo IDs
ClosedPublic
Actions

Authored by ashoat on Mar 1 2025, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 2:46 PM
Unknown Object (File)
Mon, Apr 7, 10:48 AM
Unknown Object (File)
Mon, Apr 7, 10:13 AM
Unknown Object (File)
Sun, Apr 6, 4:04 AM
Unknown Object (File)
Wed, Apr 2, 1:04 AM
Unknown Object (File)
Sat, Mar 29, 10:39 AM
Unknown Object (File)
Tue, Mar 18, 10:52 AM
Unknown Object (File)
Mon, Mar 17, 1:40 PM
View All 24 Files
Subscribers
tomek

Details

Reviewers
bartek
angelika
Commits
rCOMM58b54d14e595: [native] Allow useIntentionalSaveMedia to be called with messageInfo IDs
Summary

When ImageModal is rendered from ThreadSettingsMediaGallery, we don't know the MessageInfo. I found this out while investigating ENG-10293.

This diff makes it possible to render ImageModal without that context. In the next diff, we will fix up the callsite in ThreadSettingsMediaGallery.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/imagemodaltypes
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
media/
18 lines
28 lines
2 lines

Diff 47326

View Options

native/media/image-modal.react.js

Loading...
View Options

native/media/save-media.js

Loading...
View Options

native/media/video-playback-modal.react.js

Loading...