Differential D14441

[native] handle Desktop icon in Linked Devices screen
ClosedPublic
Actions

Authored by kamil on Mar 13 2025, 7:51 AM.

Tags

None

Referenced Files

	F6297547: D14441.diff
	Sat, Apr 26, 4:29 AM

	F6297512: D14441.diff
	Sat, Apr 26, 4:28 AM

	F6297052: D14441.diff
	Sat, Apr 26, 4:18 AM

	F6297009: D14441.diff
	Sat, Apr 26, 4:17 AM

	F6296557: D14441.diff
	Sat, Apr 26, 4:08 AM

	Unknown Object (File)
	Thu, Apr 24, 6:39 PM

	Unknown Object (File)
	Thu, Apr 24, 6:03 AM

	Unknown Object (File)
	Sat, Apr 19, 3:14 AM

View All 30 Files

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMM2d0e442ad9a9: [native] handle Desktop icon in Linked Devices screen

Summary

Screenshot 2025-03-13 at 15.49.49.jpeg (2×1 px, 233 KB)

Test Plan

Mocked adding a desktop device and look if icon is correct.

Diff Detail

Repository

Branch

followups

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 13 2025, 7:51 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 13 2025, 7:51 AM

kamil published this revision for review.Mar 13 2025, 7:52 AM

kamil edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B33714: Diff 47394!Mar 13 2025, 8:00 AM

tomek accepted this revision.Mar 13 2025, 8:10 AM

This revision is now accepted and ready to land.Mar 13 2025, 8:10 AM

Harbormaster completed remote builds in B33714: Diff 47394.Mar 13 2025, 8:14 AM

Closed by commit rCOMM2d0e442ad9a9: [native] handle Desktop icon in Linked Devices screen (authored by kamil). · Explain WhyMar 13 2025, 8:34 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2d0e442ad9a9: [native] handle Desktop icon in Linked Devices screen.

Revision Contents
Changeset List

Path

Size

native/

profile/

linked-devices-list-item.react.js

5 lines

Diff 47394

native/profile/linked-devices-list-item.react.js

	steps:			steps:
	- label: ':ios: iOS Build'			- label: ':ios: iOS Build'
	command:			command:
	- 'pod repo update && yarn workspace native clean-ios'			- 'pod repo update && yarn workspace native clean-ios'
	- 'curl --proto "=https" --tlsv1.2 -sSf https://sh.rustup.rs \| sh -s -- -y'			- 'curl --proto "=https" --tlsv1.2 -sSf https://sh.rustup.rs \| sh -s -- -y --default-toolchain stable'
	- 'source /Users/comm/.cargo/env'			- 'source /Users/comm/.cargo/env'
	- 'yarn ci-cleaninstall'			- 'yarn ci-cleaninstall'
	- 'cd native && yarn xcodebuild -workspace Comm.xcworkspace -scheme Comm -destination generic/platform=iOS -allowProvisioningUpdates'			- 'cd native && yarn xcodebuild -workspace Comm.xcworkspace -scheme Comm -destination generic/platform=iOS -allowProvisioningUpdates'
	retry:			retry:
	automatic: true			automatic: true
	env:			env:
	PROTOC: '/opt/homebrew/bin/protoc'			PROTOC: '/opt/homebrew/bin/protoc'
	agents:			agents:
	- 'mac=true'			- 'mac=true'