[native] add loading state to removing device button
ClosedPublic
Actions

Authored by kamil on Thu, Mar 13, 7:35 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM1c637384eff9: [native] add loading state to removing device button

Summary

ENG-10303.

Enabled (no changes):

Removing:

Video:

Test Plan

Tested removing device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Mar 13, 7:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Mar 13, 7:35 AM

kamil published this revision for review.Thu, Mar 13, 7:37 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/profile/linked-devices-bottom-sheet.react.js
70–108 ↗	(On Diff #47393)	I refactored this a bit to better handle errors

Harbormaster completed remote builds in B33713: Diff 47393.Thu, Mar 13, 8:03 AM

The button height changes a bit after it enters the loading state.

This revision is now accepted and ready to land.Thu, Mar 13, 8:09 AM

kamil edited the summary of this revision. (Show Details)Thu, Mar 13, 8:21 AM

avoid button height change

This revision was landed with ongoing or failed builds.Thu, Mar 13, 8:34 AM

Closed by commit rCOMM1c637384eff9: [native] add loading state to removing device button (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1c637384eff9: [native] add loading state to removing device button.

Harbormaster completed remote builds in B33716: Diff 47397.Thu, Mar 13, 8:40 AM

Revision Contents
Changeset List

Path

Size

native/

profile/

linked-devices-bottom-sheet.react.js

109 lines

Diff 47397

View Options

native/profile/linked-devices-bottom-sheet.react.js

Show All 20 Lines	RUN if [ $(echo $TARGETPLATFORM \| cut -d / -f2) = "arm64" ]; then \
else \		else \
curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"; \		curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"; \
fi		fi
RUN unzip -q awscliv2.zip && ./aws/install \		RUN unzip -q awscliv2.zip && ./aws/install \
&& rm -rf awscliv2.zip aws		&& rm -rf awscliv2.zip aws

WORKDIR /home/root/services/commtest		WORKDIR /home/root/services/commtest

		# Add the Rust target for ARM64 architecture
		RUN rustup target add aarch64-unknown-linux-gnu

# Install cargo lambda		# Install cargo lambda
RUN pip3 install cargo-lambda		RUN pip3 install cargo-lambda

# Install more recent version of protobuf, must be ran as root		# Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh		COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh		RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse		ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse

Show All 15 Lines

[native] add loading state to removing device buttonClosedPublicActions