[native] add loading state to removing device button
ClosedPublic
Actions

Authored by kamil on Mar 13 2025, 2:35 PM.

Tags

None

Referenced Files

	F33098565: D14440.1768469767.diff
	Wed, Jan 14, 9:36 AM

	F33098536: D14440.1768469745.diff
	Wed, Jan 14, 9:35 AM

	F33098492: D14440.1768469697.diff
	Wed, Jan 14, 9:34 AM

	F33098489: D14440.1768469695.diff
	Wed, Jan 14, 9:34 AM

	F4897478: ScreenRecording_03-13-2025 16-18-58_1.MP4
	Mar 13 2025, 3:21 PM

	F4897050: ScreenRecording_03-13-2025 15-26-17_1.MP4
	Mar 13 2025, 2:37 PM

	F4897047: IMG_0018.PNG
	Mar 13 2025, 2:37 PM

	F4897046: IMG_0017.PNG
	Mar 13 2025, 2:37 PM

Subscribers

ashoat

Details

Reviewers

tomek
bartek

Commits

rCOMM1c637384eff9: [native] add loading state to removing device button

Summary

ENG-10303.

Enabled (no changes):

Removing:

Video:

Test Plan

Tested removing device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 13 2025, 2:35 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 13 2025, 2:35 PM

kamil published this revision for review.Mar 13 2025, 2:37 PM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/profile/linked-devices-bottom-sheet.react.js
70–108 ↗	(On Diff #47393)	I refactored this a bit to better handle errors

Harbormaster completed remote builds in B33713: Diff 47393.Mar 13 2025, 3:03 PM

The button height changes a bit after it enters the loading state.

This revision is now accepted and ready to land.Mar 13 2025, 3:09 PM

kamil edited the summary of this revision. (Show Details)Mar 13 2025, 3:21 PM

avoid button height change

This revision was landed with ongoing or failed builds.Mar 13 2025, 3:34 PM

Closed by commit rCOMM1c637384eff9: [native] add loading state to removing device button. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1c637384eff9: [native] add loading state to removing device button.

Harbormaster completed remote builds in B33716: Diff 47397.Mar 13 2025, 3:40 PM

Revision Contents
Changeset List

Path

Size

native/

profile/

linked-devices-bottom-sheet.react.js

109 lines

Diff 47397

View Options

native/profile/linked-devices-bottom-sheet.react.js

[native] add loading state to removing device buttonClosedPublicActions