Paths

Table of Contentst

[lib][web][native] display badge only for errors
ClosedPublic
Actions

Authored by kamil on Jun 3 2025, 1:49 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMMdb65fb71eff7: [lib][web][native] display badge only for errors

Summary

ENG-10765.

Approach with examples can be found in this comment.

Depends on D14810

Test Plan

Tested logs filtering
Tested copying & clearing
Tested badge value

Diff Detail

Repository

rCOMM Comm

Branch

pub-encr

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 3 2025, 1:49 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 3 2025, 1:49 PM

Harbormaster completed remote builds in B34365: Diff 48416.Jun 3 2025, 2:08 PM

kamil published this revision for review.Jun 3 2025, 2:09 PM

bartek accepted this revision.Jun 4 2025, 10:18 AM

bartek added inline comments.

lib/components/debug-logs-context.js
33	Nit: `errorLogsCount` would be more correct, but doesn't matter

tomek accepted this revision.Jun 5 2025, 2:07 PM

tomek added inline comments.

lib/components/debug-logs-context-provider.react.js
26–39	Why do we need these changes?

This revision is now accepted and ready to land.Jun 5 2025, 2:07 PM

errorLogsNumber -> errorLogsCount

lib/components/debug-logs-context-provider.react.js
26–39	to avoid duplication with imported `logTypes`
lib/components/debug-logs-context.js
33	updated

Harbormaster completed remote builds in B34380: Diff 48446.Jun 9 2025, 10:18 AM

Closed by commit rCOMMdb65fb71eff7: [lib][web][native] display badge only for errors. · Explain WhyJun 9 2025, 10:29 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdb65fb71eff7: [lib][web][native] display badge only for errors.

Revision Contents
Changeset List

Path

Size

lib/

components/

debug-logs-context-provider.react.js

13 lines

debug-logs-context.js

2 lines

native/

navigation/

tab-navigator.react.js

4 lines

web/

sidebar/

community-picker.react.js

8 lines

Diff 48416

View Options

lib/components/debug-logs-context-provider.react.js

View Options

lib/components/debug-logs-context.js

View Options

native/navigation/tab-navigator.react.js

View Options

web/sidebar/community-picker.react.js

[lib][web][native] display badge only for errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48416

lib/components/debug-logs-context-provider.react.js

lib/components/debug-logs-context.js

native/navigation/tab-navigator.react.js

web/sidebar/community-picker.react.js

[lib][web][native] display badge only for errors
ClosedPublic
Actions

Revision Contents
Changeset List