[native] update `updateSQLiteUnreadStatus` to check for thread type
ClosedPublic
Actions

Authored by kamil on Jun 18 2025, 1:32 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM73cbfb0ef393: [native] update `updateSQLiteUnreadStatus` to check for thread type

Summary

ENG-10953.

Depends on D14858

Test Plan

Carefully reading the code. Unable to test actual functionality because of ENG-10959

Diff Detail

Repository

rCOMM Comm

Branch

publish-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 18 2025, 1:32 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 18 2025, 1:32 PM

kamil edited the summary of this revision. (Show Details)Jun 18 2025, 1:32 PM

Harbormaster completed remote builds in B34439: Diff 48533.Jun 18 2025, 1:58 PM

kamil retitled this revision from [SQLite] update `updateSQLiteUnreadStatus` to check for thread type to [native] update `updateSQLiteUnreadStatus` to check for thread type.Jun 18 2025, 2:03 PM

kamil added a child revision: D14860: [native] update `storeMessageInfos` to check for thread type.Jun 18 2025, 2:04 PM

kamil published this revision for review.Jun 18 2025, 2:05 PM

tomek accepted this revision.Jun 23 2025, 12:06 PM

This revision is now accepted and ready to land.Jun 23 2025, 12:06 PM

tomek added inline comments.Jun 23 2025, 12:07 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
118	It might be more maintainable if we used `dataIsBackedUp` instead

isRegularTable -> dataIsBackedUp

The ENG-10959 blocks testing actual functionality, but the only change here is adding threadIDMatchesKeyserverProtocol check, which was tested well using tests in D14858. Because of that, I am going to land it to unblock Stop backing up thin thread data project, but I'll make sure to test both thin and thick thread notifs while working on ENG-10959.