Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/redux/client-db-utils.js | ||
|---|---|---|
| 49 ↗ | (On Diff #48535) | This now has hardcoded isBackedUp so shouldn't be used. We can't use computed isBackedUp because it will change the behaviour of the existing migration. This is used in only one place so I think it is okay, and this is pattern I've seen in multiple places in codebase |
| native/redux/deprecated-client-db-utils.js | ||
| 89 ↗ | (On Diff #48535) | Only for types, this method is deprecated, and adding false is not changing anything |
| native/redux/client-db-utils.js | ||
|---|---|---|
| 49 ↗ | (On Diff #48535) | Usually, it is a good idea to present a new solution when deprecating the existing one. This function is quite simple, so if someone needs a new function, it can be created quite easily. |
| native/redux/client-db-utils.js | ||
|---|---|---|
| 49 ↗ | (On Diff #48535) | I agree, but I don't think there will be a need for a function like this in the future - this is just a chunk of code from one migration that was extracted to a separate function, which I think was a bad idea |