Paths

Table of Contentst

Differential D15169

[native] Let backup error screen display different error types
ClosedPublic
Actions

Authored by bartek on Aug 6 2025, 7:59 AM.

Tags

None

Referenced Files

	F32160932: D15169.1765042061.diff
	Fri, Dec 5, 5:27 PM

Subscribers

Details

Reviewers

Commits

rCOMM8212609ffb38: [native] Let backup error screen display different error types

Summary

Part of ENG-11011, native counterpart of D15163 refactor

Depends on D15164

Test Plan

Restore errors are displayed the same as before. "Simple errors" tested in the next diff

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 6 2025, 7:59 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 6 2025, 7:59 AM

bartek added a child revision: D15170: [native] Handle QR and UserKeys error in restore UI.Aug 6 2025, 8:00 AM

Harbormaster completed remote builds in B35047: Diff 49286.Aug 6 2025, 8:17 AM

bartek published this revision for review.Aug 6 2025, 9:16 AM

kamil accepted this revision.Aug 6 2025, 10:11 AM

kamil added inline comments.

native/account/restore-backup-error-screen.react.js
194 ↗	(On Diff #49286)	Shouldn't we add this here?
201 ↗	(On Diff #49286)	I would define this close to `ScreenProps` because it is hard to read

This revision is now accepted and ready to land.Aug 6 2025, 10:11 AM

bartek added inline comments.Aug 6 2025, 10:50 AM

native/account/restore-backup-error-screen.react.js
194 ↗	(On Diff #49286)	No, because this is not a data corruption error, but rather a different, usually retriable issue
201 ↗	(On Diff #49286)	Good call

Address feedback

Harbormaster failed remote builds in B35054: Diff 49294!Aug 6 2025, 11:10 AM

This revision was landed with ongoing or failed builds.Aug 6 2025, 11:54 AM

Closed by commit rCOMM8212609ffb38: [native] Let backup error screen display different error types. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8212609ffb38: [native] Let backup error screen display different error types.

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth-progress-screen.react.js

5 lines

restore-backup-error-screen.react.js

152 lines

restore-backup-screen.react.js

11 lines

Diff 49294

native/account/qr-auth-progress-screen.react.js

Loading...

native/account/restore-backup-error-screen.react.js

Loading...

native/account/restore-backup-screen.react.js

Loading...