Details
Details
- Reviewers
bartek tomek - Commits
- rCOMM74987983ff95: [tunnelbroker] implement TokenConnection
Tested later in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- publish-tokens-2
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/tunnelbroker/src/token_distributor/error.rs | ||
|---|---|---|
| 1 ↗ | (On Diff #49982) | it's more clear inside the From impl below |
| 4–47 ↗ | (On Diff #49982) | I think using #[derive(Display)] is more concise, but this one is good too. docs: https://jeltef.github.io/derive_more/derive_more/display.html |
| 49–57 ↗ | (On Diff #49982) | Nice job on this! This is the correct impl since derive error doesn't work well in such cases. |
| services/tunnelbroker/src/token_distributor/token_connection.rs | ||
| 92 ↗ | (On Diff #49982) | Nit: this e variable shadows the outer e |
| 228 ↗ | (On Diff #49982) | I'd lower this to trace, I have a suspicion this will spam too much. |