Differential D15244

[lib] update permissions for Farcaster 1-1 messages
ClosedPublic
Actions

Authored by kamil on Aug 27 2025, 12:03 PM.

Details

Reviewers

tomek

Commits

rCOMM1d7f6d06c779: [lib] update permissions for Farcaster 1-1 messages

Summary

ENG-10922.

This is different than color change, which is not supported by Farcaster at all. Change thread name and description is allowed but only in specific case (group & being an admin).

Depends on D15243

Test Plan

teste later in the stack

Diff Detail

Repository

rCOMM Comm

Branch

landing

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 27 2025, 12:03 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2025, 12:03 PM

kamil mentioned this in D15245: [web] fix permission check for description.Aug 27 2025, 12:05 PM

Harbormaster failed remote builds in B35547: Diff 50028!Aug 27 2025, 12:08 PM

kamil added a child revision: D15245: [web] fix permission check for description.Aug 27 2025, 12:11 PM

kamil edited the summary of this revision. (Show Details)

kamil added a parent revision: D15243: [lib] fix cycle dependency in `farcaster-utils.js`.

kamil published this revision for review.Aug 27 2025, 12:22 PM

tomek accepted this revision.Aug 28 2025, 9:54 AM

tomek added inline comments.

lib/permissions/farcaster-permissions.js
82–84 ↗	(On Diff #50028)	We can delete these instead

This revision is now accepted and ready to land.Aug 28 2025, 9:54 AM

delete permissions

Harbormaster failed remote builds in B35567: Diff 50051!Aug 28 2025, 10:30 AM

This revision was landed with ongoing or failed builds.Aug 28 2025, 12:03 PM

Closed by commit rCOMM1d7f6d06c779: [lib] update permissions for Farcaster 1-1 messages. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1d7f6d06c779: [lib] update permissions for Farcaster 1-1 messages.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

farcaster-permissions.js

3 lines

utils/

create-farcaster-raw-thread-info.js

17 lines

Diff 50051

View Options

lib/permissions/farcaster-permissions.js