[tunnelbroker] call `cancellation_token` when connection ends
ClosedPublic
Actions

Authored by kamil on Sep 5 2025, 12:41 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM25ed0cb779b4: [tunnelbroker] call `cancellation_token` when connection ends

Summary

ENG-11219

Test Plan

Run Tunnelbroker, check in logs how many connections are opened
Delete one token from DDB
Check if this is reflected in logs

Diff Detail

Repository

rCOMM Comm

Branch

tb-improvement

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 5 2025, 12:41 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2025, 12:41 PM

kamil published this revision for review.Sep 5 2025, 12:41 PM

bartek accepted this revision.Sep 5 2025, 1:00 PM

bartek added inline comments.

services/tunnelbroker/src/token_distributor/token_connection.rs
58	perhaps we should redact it

This revision is now accepted and ready to land.Sep 5 2025, 1:00 PM

Harbormaster completed remote builds in B35643: Diff 50181.Sep 5 2025, 1:00 PM

kamil added inline comments.Sep 5 2025, 1:12 PM

services/tunnelbroker/src/token_distributor/token_connection.rs
58	There are more places where we can do it, created ENG-11221

Closed by commit rCOMM25ed0cb779b4: [tunnelbroker] call `cancellation_token` when connection ends. · Explain WhySep 5 2025, 1:28 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM25ed0cb779b4: [tunnelbroker] call `cancellation_token` when connection ends.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

token_distributor/

token_connection.rs

92 lines

Diff 50181

View Options

services/tunnelbroker/src/token_distributor/token_connection.rs

[tunnelbroker] call `cancellation_token` when connection endsClosedPublicActions