Paths

Table of Contentst

Differential D15370

[tunnelbroker] Extract utility to send messages
ClosedPublic
Actions

Authored by bartek on Sep 18 2025, 8:14 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM14d9a9079c5b: [tunnelbroker] Extract utility to send messages

Summary

Small refactor that makes sending messages more convenient and self-contained.

Depends on D15369

Test Plan

Tested later in the stack

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 18 2025, 8:14 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2025, 8:14 AM

Harbormaster failed remote builds in B35779: Diff 50378!Sep 18 2025, 8:21 AM

bartek added a child revision: D15371: [tunnelbroker] Implement server-native notif client.Sep 18 2025, 8:22 AM

Rebase

Harbormaster failed remote builds in B35784: Diff 50383!Sep 18 2025, 9:01 AM

bartek published this revision for review.Sep 18 2025, 9:29 AM

bartek added inline comments.

services/tunnelbroker/src/token_distributor/token_connection.rs
546–560	Here I moved the payload outside the for loop to avoid unnecessary serialization with each iteration Fixed Clippy warn of unused `platform_details` - replaced with `.keys()` to get only device ID

tomek accepted this revision.Sep 18 2025, 10:41 AM

This revision is now accepted and ready to land.Sep 18 2025, 10:41 AM

tomek added inline comments.Sep 18 2025, 10:42 AM

services/tunnelbroker/src/token_distributor/token_connection.rs
555–565	Now I'm wondering if we should filter out the keyservers here

Filter out keyservers

Harbormaster failed remote builds in B35797: Diff 50410!Sep 19 2025, 10:18 AM

This revision was landed with ongoing or failed builds.Sep 19 2025, 3:54 PM

Closed by commit rCOMM14d9a9079c5b: [tunnelbroker] Extract utility to send messages. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM14d9a9079c5b: [tunnelbroker] Extract utility to send messages.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

amqp_client/

54 lines

1 line

108 lines

grpc/

6 lines

token_distributor/

token_connection.rs

52 lines

Diff 50383

services/tunnelbroker/src/amqp_client/amqp.rs

Loading...

services/tunnelbroker/src/amqp_client/mod.rs

Loading...

services/tunnelbroker/src/amqp_client/utils.rs

Loading...

services/tunnelbroker/src/grpc/mod.rs

Loading...

services/tunnelbroker/src/token_distributor/token_connection.rs

Loading...