[tunnelbroker] Send notifs on FC conversation refresh
ClosedPublic
Actions

Authored by bartek on Sep 18 2025, 8:28 AM.

Details

Reviewers

tomek

Commits

rCOMMc94f37d6e1f5: [tunnelbroker] Send notifs on FC conversation refresh

Summary

Updated stream's "refresh conversation" handler to

fetch conversation details
prepare notif payload
send notif to all devices from user's device list

Notif is only sent in case of receiving a text message from other participants, in a non-muted conversation.

Depends on D15372

Test Plan

Commented-out the self-sender check, then sent some text and multimedia DCs. Verified that I received notifs on all my devices.
Uncommented the check, no notifs were seen.
Verified that mute option is respected.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 18 2025, 8:28 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2025, 8:28 AM

Harbormaster failed remote builds in B35782: Diff 50381!Sep 18 2025, 8:35 AM

Rebase

Harbormaster failed remote builds in B35787: Diff 50386!Sep 18 2025, 9:05 AM

bartek published this revision for review.Sep 18 2025, 9:30 AM

bartek added inline comments.

services/tunnelbroker/src/token_distributor/notif_utils.rs
20	I'd consider badges as follow-ups because I have no context on how we manage them and when they're cleared.
49	Potentially I could use `sender_fid` and above `conversation.participant()` to get sender name, then do something like `Bartek sent a photo`.
57–58	These are values from client-side code
59	Based on farcasterIDPrefix

tomek accepted this revision.Sep 18 2025, 10:53 AM

tomek added inline comments.

services/tunnelbroker/src/token_distributor/token_connection.rs
513–524	Not sure about error handling here. When this call fails, we won't schedule messages to clients. Can we make these more independent - so if this fails, only the notifs aren't sent?
522	It is risky to rely on this. Can we expose the FID from a farcaster_client? Or is there some other way of getting it?

This revision is now accepted and ready to land.Sep 18 2025, 10:53 AM

bartek added a child revision: D15378: Fix clippy warnings.Sep 19 2025, 9:54 AM

bartek added inline comments.Sep 19 2025, 10:24 AM

services/tunnelbroker/src/token_distributor/token_connection.rs
513–524	Yes, your concern is valid, I can refactor this function to fix this problem
522	Yeah I know it's risky, but it's the fastest and sync. Also, if it stopped working, it'd only cause notifs being sent to ourselves when we send messages. I'll see if there's an easy way to get it from DDB, without additional calls