Details
Details
- Reviewers
bartek - Commits
- rCOMM745fe7f68005: [tunnelbroker] Improve notif payload creation
Tested locally for a photo message, full test plan was in D15373
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
CI failures unrelated, it's because of me being badly rebased
| services/tunnelbroker/src/token_distributor/notif_utils.rs | ||
|---|---|---|
| 57 | Can possibly be simplified, at the cost of being less explicit Generally, 🐮 (Cow - clone on write) is a fun utility that keeps either an owned object (String) or a borrowed reference (&str) to avoid cloning/copying (creating a new owned object from a reference) when it's unnecessary. | |
| 60–75 | Technically, this could be refactored to 🐄 too - we don't have to clone the string when the original didn't change | |