Differential D15387
[lib][native][web] Track connecting Farcaster DC alert separate from connecting Farcaster alert Authored by ashoat on Sep 26 2025, 8:23 PM.
Details We currently use the same alertTypes constant for both of these. This has a risk that a non-staff user with a new build would see the "connect Farcaster" alert, choose to enable it, and then never see the "connect Farcaster DC" alert because shouldSkipConnectFarcasterAlert filters after you see the alert once. To add this new alertTypes constant we need to make sure it's present in the Redux store on native. Careful code inspection and Flow
Diff Detail
Event Timeline
Comment Actions
This isn't correct. In https://github.com/CommE2E/comm/blob/29cb2007b37e28cec94cc80c5389cdb08a9cb723/native/components/connect-farcaster-alert-handler.react.js#L55 we're checking a flag that is false for non-staff users, which means the alert won't be shown at all. Regardless, handling these separately might be an improvement. | ||||||||||