Page MenuHomePhabricator
Differential D3186

[services][refactoring] Tunnelbroker - Remove unique pointers from CryptoTools.
ClosedPublic
Actions

Authored by • max on Feb 12 2022, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 10:44 AM
Unknown Object (File)
Sat, Nov 2, 7:20 AM
Unknown Object (File)
Sat, Nov 2, 7:20 AM
Unknown Object (File)
Sat, Nov 2, 7:20 AM
Unknown Object (File)
Sat, Nov 2, 7:20 AM
Unknown Object (File)
Sat, Nov 2, 7:09 AM
Unknown Object (File)
Thu, Oct 17, 6:53 AM
Unknown Object (File)
Oct 16 2024, 8:25 AM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
ashoat
• jim
Commits
rCOMM5e1172cfc123: [services][refactoring] Tunnelbroker - Remove unique pointers from CryptoTools.
Summary

We are aware of memory leaks using the new allocation for the cryptoPP classes and used unique pointers and release().
According to the CryptoPP pipeline documentation, we don't need to free the memory manually and can switch to the new approach because using unique pointers and release() have no makes sense here.

Related linear task: ENG-627

Test Plan

Successfully built the server and verify the string by the rsaVerifyString function.

Diff Detail

Repository
rCOMM Comm
Branch
cryptopp
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Feb 12 2022, 11:58 PM
Herald added subscribers: • karol, atul, • adrian and 2 others. · View Herald TranscriptFeb 12 2022, 11:58 PM
• max edited the summary of this revision. (Show Details)Feb 12 2022, 11:59 PM
• max added reviewers: • karol, tomek.
Harbormaster completed remote builds in B6769: Diff 9591.Feb 13 2022, 12:02 AM
• max requested review of this revision.Feb 13 2022, 12:02 AM
tomek accepted this revision.Feb 14 2022, 6:01 AM
This revision is now accepted and ready to land.Feb 14 2022, 6:01 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 14 2022, 6:01 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 14 2022, 6:01 AM
ashoat accepted this revision.Feb 14 2022, 8:54 PM
ashoat added a reviewer: • jim.

Awesome, thanks for following up on this. Making and then releasing a unique_ptr never made sense to me...

This revision is now accepted and ready to land.Feb 14 2022, 8:54 PM
• max updated this revision to Diff 9692.Feb 15 2022, 11:46 AM

Rebase.

This revision was landed with ongoing or failed builds.Feb 15 2022, 11:51 AM
Closed by commit rCOMM5e1172cfc123: [services][refactoring] Tunnelbroker - Remove unique pointers from CryptoTools. (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM5e1172cfc123: [services][refactoring] Tunnelbroker - Remove unique pointers from CryptoTools..
Harbormaster completed remote builds in B6849: Diff 9692.Feb 15 2022, 11:51 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
docker-server/
contents/
server/
src/
Tools/
20 lines

Diff 9591

View Options

services/tunnelbroker/docker-server/contents/server/src/Tools/CryptoTools.cpp

Loading...