Page MenuHomePhabricator
Differential D3204

Revert "[web] [darkmode] unread button"
ClosedPublic
Actions

Authored by • benschac on Feb 15 2022, 7:22 AM.
Tags
None
Referenced Files
F6239668: D3204.id9679.diff
Thu, Apr 24, 8:47 PM
Unknown Object (File)
Fri, Apr 18, 2:08 PM
Unknown Object (File)
Fri, Apr 18, 12:54 PM
Unknown Object (File)
Fri, Apr 18, 6:00 AM
Unknown Object (File)
Thu, Apr 17, 5:12 AM
Unknown Object (File)
Tue, Apr 15, 3:36 AM
Unknown Object (File)
Sat, Apr 12, 7:34 PM
Unknown Object (File)
Thu, Apr 10, 12:38 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM3ca1a0bf4b55: Revert "[web] [darkmode] unread button"
Summary

This reverts commit fb93ae4b58bab7a9c48a983fee2f9e98a74b1b8e.

Test Plan

this commit is breaking master. Styling is incorrect.

I should have waited for this diff: https://phabricator.ashoat.com/D3180 to land first.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
chat/
26 lines
12 lines
components/
13 lines
2 lines
5 lines

Diff 9679

View Options

web/chat/chat-thread-list-item-menu.react.js

// @flow // @flow
import classNames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import { import {
setThreadUnreadStatusActionTypes, setThreadUnreadStatusActionTypes,
setThreadUnreadStatus, setThreadUnreadStatus,
} from 'lib/actions/activity-actions'; } from 'lib/actions/activity-actions';
import type { import type {
SetThreadUnreadStatusPayload, SetThreadUnreadStatusPayload,
SetThreadUnreadStatusRequest, SetThreadUnreadStatusRequest,
} from 'lib/types/activity-types'; } from 'lib/types/activity-types';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import Button from '../components/button.react';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './chat-thread-list.css'; import css from './chat-thread-list.css';
type Props = { type Props = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
+mostRecentNonLocalMessage: ?string, +mostRecentNonLocalMessage: ?string,
+renderStyle?: 'chat' | 'thread', +renderStyle?: 'chat' | 'thread',
}; };
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines const toggleUnreadStatus = React.useCallback(() => {
boundSetThreadUnreadStatus, boundSetThreadUnreadStatus,
]); ]);
const toggleUnreadStatusButtonText = `Mark as ${ const toggleUnreadStatusButtonText = `Mark as ${
threadInfo.currentUser.unread ? 'read' : 'unread' threadInfo.currentUser.unread ? 'read' : 'unread'
}`; }`;
const menuIconSize = renderStyle === 'chat' ? 24 : 16; const menuIconSize = renderStyle === 'chat' ? 24 : 16;
let btn;
if (menuVisible) {
btn = (
<Button variant="toggle_read" onClick={toggleUnreadStatus}>
{toggleUnreadStatusButtonText}
</Button>
);
}
return ( return (
<div className={css.menu} onMouseLeave={hideMenu}> <div className={css.menu} onMouseLeave={hideMenu}>
<button onClick={toggleMenu}> <button onClick={toggleMenu}>
<SWMansionIcon icon="menu-vertical" size={menuIconSize} /> <SWMansionIcon icon="menu-vertical" size={menuIconSize} />
</button> </button>
<div>{btn}</div> <div
className={classNames(css.menuContent, {
[css.menuContentVisible]: menuVisible,
})}
>
<ul>
<li>
<button onClick={toggleUnreadStatus}>
{toggleUnreadStatusButtonText}
</button>
</li>
</ul>
</div>
</div> </div>
); );
} }
export default ChatThreadListItemMenu; export default ChatThreadListItemMenu;
View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/components/button.css

Loading...
View Options

web/components/button.react.js

// @flow // @flow
import classnames from 'classnames'; import classnames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import css from './button.css'; import css from './button.css';
type Props = { type Props = {
+onClick: (event: SyntheticEvent<HTMLButtonElement>) => void, +onClick: (event: SyntheticEvent<HTMLButtonElement>) => void,
+children: React.Node, +children: React.Node,
+variant?: 'primary' | 'secondary' | 'danger' | 'round' | 'toggle_read', +variant?: 'primary' | 'secondary' | 'danger' | 'round',
+type?: string, +type?: string,
+disabled?: boolean, +disabled?: boolean,
+className?: string, +className?: string,
}; };
function Button(props: Props): React.Node { function Button(props: Props): React.Node {
const { const {
onClick, onClick,
Show All 21 Lines
View Options

web/theme.css

Loading...