Page MenuHomePhabricator
Differential D3231

[landing] [fix] button header on mobile breaking layout
ClosedPublic
Actions

Authored by • benschac on Feb 16 2022, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 7:02 AM
Unknown Object (File)
Tue, Apr 1, 9:17 AM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Mon, Mar 24, 10:35 AM
Unknown Object (File)
Wed, Mar 12, 1:20 PM
Unknown Object (File)
Mar 4 2025, 9:21 PM
Unknown Object (File)
Feb 20 2025, 8:15 PM
Unknown Object (File)
Feb 20 2025, 8:15 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM3221ca8ecd8c: [landing] [fix] button header on mobile breaking layout
Summary

fix header so button in header doesn't show on mobile

before:

Image 2022-02-16 at 1.37.02 PM.jpg (1×1 px, 116 KB)

after:

Image 2022-02-16 at 1.36.54 PM.jpg (1×1 px, 119 KB)

(side stepping normal PR review because we have a lot of folks looking at the webpage this week.) I felt this was urgent to fix.

Test Plan

shrink viewport to show break point is working as expected and layout isn't broken

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 9745

View Options

landing/header.css

Show All 22 Linesvoid DatabaseManager::innerPutItem(
const Aws::DynamoDB::Model::PutItemRequest &request) { const Aws::DynamoDB::Model::PutItemRequest &request) {
const Aws::DynamoDB::Model::PutItemOutcome outcome = const Aws::DynamoDB::Model::PutItemOutcome outcome =
getDynamoDBClient()->PutItem(request); getDynamoDBClient()->PutItem(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
} }
void DatabaseManager::innerRemoveItem( void DatabaseManager::innerRemoveItem(const Item &item) {
const Item &item,
const std::string &key) {
Aws::DynamoDB::Model::DeleteItemRequest request; Aws::DynamoDB::Model::DeleteItemRequest request;
request.SetTableName(item.getTableName()); request.SetTableName(item.getTableName());
PrimaryKey pk = item.getPrimaryKey();
PrimaryKeyValue primaryKeyValue = item.getPrimaryKeyValue();
request.AddKey( request.AddKey(
item.getPrimaryKey().partitionKey, pk.partitionKey,
Aws::DynamoDB::Model::AttributeValue(key)); Aws::DynamoDB::Model::AttributeValue(primaryKeyValue.partitionKey));
if (pk.sortKey != nullptr && primaryKeyValue.sortKey != nullptr) {
request.AddKey(
*pk.sortKey,
Aws::DynamoDB::Model::AttributeValue(*primaryKeyValue.sortKey));
}
const Aws::DynamoDB::Model::DeleteItemOutcome &outcome = const Aws::DynamoDB::Model::DeleteItemOutcome &outcome =
getDynamoDBClient()->DeleteItem(request); getDynamoDBClient()->DeleteItem(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
} }
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 LinesDatabaseManager::findLastBackupItem(const std::string &userID) {
const Aws::Vector<AttributeValues> &items = outcome.GetResult().GetItems(); const Aws::Vector<AttributeValues> &items = outcome.GetResult().GetItems();
if (items.empty()) { if (items.empty()) {
return nullptr; return nullptr;
} }
return std::make_shared<database::BackupItem>(items[0]); return std::make_shared<database::BackupItem>(items[0]);
} }
void DatabaseManager::removeBackupItem(std::shared_ptr<BackupItem> item) { void DatabaseManager::removeBackupItem(std::shared_ptr<BackupItem> item) {
Aws::DynamoDB::Model::DeleteItemRequest request; this->innerRemoveItem(*item);
request.SetTableName(item->getTableName());
request.AddKey(
BackupItem::FIELD_USER_ID,
Aws::DynamoDB::Model::AttributeValue(item->getUserID()));
request.AddKey(
BackupItem::FIELD_BACKUP_ID,
Aws::DynamoDB::Model::AttributeValue(item->getBackupID()));
const Aws::DynamoDB::Model::DeleteItemOutcome &outcome =
comm::network::getDynamoDBClient()->DeleteItem(request);
if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage());
}
} }
void DatabaseManager::putLogItem(const LogItem &item) { void DatabaseManager::putLogItem(const LogItem &item) {
Aws::DynamoDB::Model::PutItemRequest request; Aws::DynamoDB::Model::PutItemRequest request;
request.SetTableName(LogItem::tableName); request.SetTableName(LogItem::tableName);
request.AddItem( request.AddItem(
LogItem::FIELD_BACKUP_ID, LogItem::FIELD_BACKUP_ID,
Aws::DynamoDB::Model::AttributeValue(item.getBackupID())); Aws::DynamoDB::Model::AttributeValue(item.getBackupID()));
Show All 37 LinesDatabaseManager::findLogItemsForBackup(const std::string &backupID) {
for (auto &item : items) { for (auto &item : items) {
result.push_back(std::make_shared<database::LogItem>(item)); result.push_back(std::make_shared<database::LogItem>(item));
} }
return result; return result;
} }
void DatabaseManager::removeLogItem(std::shared_ptr<LogItem> item) { void DatabaseManager::removeLogItem(std::shared_ptr<LogItem> item) {
Aws::DynamoDB::Model::DeleteItemRequest request; this->innerRemoveItem(*item);
request.SetTableName(item->getTableName());
request.AddKey(
LogItem::FIELD_BACKUP_ID,
Aws::DynamoDB::Model::AttributeValue(item->getBackupID()));
request.AddKey(
LogItem::FIELD_LOG_ID,
Aws::DynamoDB::Model::AttributeValue(item->getLogID()));
const Aws::DynamoDB::Model::DeleteItemOutcome &outcome =
getDynamoDBClient()->DeleteItem(request);
if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage());
}
} }
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm