[web] [refactor] [remove] clearModal function is never used.
AbandonedPublic
Actions

Authored by • benschac on Feb 16 2022, 5:06 AM.

Details

Reviewers

atul
ashoat

Summary

clearModal function was never used. Can delete

Test Plan

N/A this was code that wasn't used

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Feb 16 2022, 5:06 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 16 2022, 5:06 AM

Harbormaster completed remote builds in B6869: Diff 9717.Feb 16 2022, 5:11 AM

• benschac requested review of this revision.Feb 16 2022, 5:11 AM

[landing] [fix] footer layout on mobile

Harbormaster completed remote builds in B6897: Diff 9747.Feb 16 2022, 11:04 AM

atul requested changes to this revision.Feb 17 2022, 10:30 AM

atul added inline comments.

landing/footer.css
21	Think this was an unrelated change related to the fixing the landing page footer on mobile?

This revision now requires changes to proceed.Feb 17 2022, 10:30 AM

diff review, remove css

diff review

Harbormaster completed remote builds in B6925: Diff 9779.Feb 18 2022, 9:43 AM

Harbormaster completed remote builds in B6927: Diff 9781.Feb 18 2022, 9:48 AM

Please make the dependency graph show up by adding "Depends on: Dwhatever" to the diff summary, and then re-request review.

This revision now requires changes to proceed.Feb 21 2022, 10:19 PM

• benschac mentioned this in D3215: [web] [refactor] create modal context, use for setModal.Feb 23 2022, 8:42 AM

Closing in favor of squashed diff stack: https://phabricator.ashoat.com/D3271

• benschac mentioned this in rCOMMb54b78480344: [web] [refactor] create modal context, use for setModal.Feb 24 2022, 1:23 PM

Revision Contents
Changeset List

Path

Size

landing/

footer.css

2 lines

web/

app.react.js

4 lines

Diff 9747

View Options

landing/footer.css