[web] [refactor] replace / remove use setModal prop drill, use context in multimedia component
AbandonedPublic
Actions

Authored by • benschac on Feb 22 2022, 1:51 PM.

Details

Reviewers

atul
ashoat

Summary

use clearModal, remove setModal prop drill

Test Plan

multimedia modal should work as expected

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Feb 22 2022, 1:51 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 22 2022, 1:51 PM

Harbormaster completed remote builds in B6954: Diff 9813.Feb 22 2022, 1:56 PM

• benschac requested review of this revision.Feb 22 2022, 1:56 PM

You're still not specifying the relationship with the rest of the stack here

This revision now requires changes to proceed.Feb 23 2022, 2:58 AM

Closing in favor of squashed diff stack: https://phabricator.ashoat.com/D3271

Revision Contents
Changeset List

Path

Size

web/

chat/

multimedia-message.react.js

15 lines

media/

multimedia-modal.react.js

16 lines

multimedia.react.js

39 lines

Diff 9813

View Options

web/chat/multimedia-message.react.js

View Options

web/media/multimedia-modal.react.js

View Options

web/media/multimedia.react.js

[web] [refactor] replace / remove use setModal prop drill, use context in multimedia componentAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9813

web/chat/multimedia-message.react.js

web/media/multimedia-modal.react.js

web/media/multimedia.react.js

[web] [refactor] replace / remove use setModal prop drill, use context in multimedia component
AbandonedPublic
Actions

Revision Contents
Changeset List