It's quite a large diff adding support for large notifs - I think it would be a lot easier to review it if it was split into multiple smaller ones. We don't have the time to split it, but overall the diff makes sense to me.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Fri, Sep 27
Fri, Sep 27
tomek committed rCOMMa432a967f452: [lib] Handle a case where viewer is added to a thread while being its member (authored by tomek).
[lib] Handle a case where viewer is added to a thread while being its member
[lib] Validate DM operations
tomek committed rCOMM082447a2d740: [lib] Check ID conflicts when processing operations (authored by tomek).
[lib] Check ID conflicts when processing operations
[lib] Update thick thread avatars logic
tomek updated the diff for D13490: [lib] Handle a case where viewer is added to a thread while being its member.
Shorthand
Use Promise.all
Fix imports
Rebase
Thu, Sep 26
Thu, Sep 26
Check create sidebar message conflicts
Validate change thread settings operation
Check message ID conflict for all the operations
Wed, Sep 25
Wed, Sep 25
Update invariant message
tomek committed rCOMM1d2bb3b72dfb: [lib] Set roles and permissions in thick threads based on parent permissions (authored by tomek).
[lib] Set roles and permissions in thick threads based on parent permissions
tomek updated the diff for D13418: [lib] Set roles and permissions in thick threads based on parent permissions.
Update comments and reorder functions
tomek requested review of D13418: [lib] Set roles and permissions in thick threads based on parent permissions.
There are a lot of changes so requesting a review:
- Get permissions from the parent even when the viewer is a member
- Use permissions from the parent when setting the permissions for non-viewer members
tomek added inline comments to D13418: [lib] Set roles and permissions in thick threads based on parent permissions.
tomek retitled D13418: [lib] Set roles and permissions in thick threads based on parent permissions from [lib] Fix roles and permissions in thick threads when viewer isn't a member to [lib] Set roles and permissions in thick threads based on parent permissions.
tomek updated the diff for D13418: [lib] Set roles and permissions in thick threads based on parent permissions.
Set permissions based on parent
Rebase
tomek committed rCOMM1bfafb3973e8: [lib] Define permissions of PERSONAL and PRIVATE threads (authored by tomek).
[lib] Define permissions of PERSONAL and PRIVATE threads