Page MenuHomePhabricator
Differential D13462

[lib] Update thick thread avatars logic
ClosedPublic
Actions

Authored by tomek on Wed, Sep 25, 8:33 AM.
Tags
None
Referenced Files
F2837939: D13462.diff
Sat, Sep 28, 8:13 PM
Unknown Object (File)
Sat, Sep 28, 2:46 PM
Unknown Object (File)
Wed, Sep 25, 12:22 PM
Subscribers
None

Details

Reviewers
kamil
will
Commits
rCOMM78023115da35: [lib] Update thick thread avatars logic
Summary

We should correctly select thick thread avatar based on user avatars.

https://linear.app/comm/issue/ENG-9374/thread-avatars-not-using-user-avatars-for-dms

Test Plan

Created personal and private thick threads and verified that on a thread list their avatars are correct, and before this diff they were incorrect.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Wed, Sep 25, 8:33 AM
tomek edited reviewers, added: will; removed: ashoat.Wed, Sep 25, 8:34 AM
tomek added inline comments.
lib/shared/avatar-utils.js
7 ↗(On Diff #44552)

Shortened the import

293 ↗(On Diff #44552)

Simplified this expression - it didn't make too much sense in the previous form

Harbormaster completed remote builds in B31844: Diff 44552.Wed, Sep 25, 8:51 AM
tomek requested review of this revision.Wed, Sep 25, 8:51 AM
will accepted this revision.Wed, Sep 25, 8:54 AM
This revision is now accepted and ready to land.Wed, Sep 25, 8:54 AM
tomek updated this revision to Diff 44556.Wed, Sep 25, 8:57 AM

Update invariant message

Harbormaster completed remote builds in B31846: Diff 44556.Wed, Sep 25, 9:15 AM
tomek updated this revision to Diff 44619.Fri, Sep 27, 2:54 AM

Rebase

tomek updated this revision to Diff 44620.Fri, Sep 27, 2:56 AM

Fix imports

Harbormaster failed remote builds in B31894: Diff 44619!Fri, Sep 27, 3:07 AM
Harbormaster completed remote builds in B31895: Diff 44620.Fri, Sep 27, 3:13 AM
Closed by commit rCOMM78023115da35: [lib] Update thick thread avatars logic (authored by tomek). · Explain WhyFri, Sep 27, 3:54 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM78023115da35: [lib] Update thick thread avatars logic.

Revision Contents
Changeset List

PathSize
lib/
shared/
17 lines
6 lines
native/
avatars/
9 lines

Diff 44624

View Options

lib/shared/avatar-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/avatars/thread-avatar.react.js

Loading...