User Details
- User Since
- Sep 30 2022, 6:32 PM (110 w, 6 d)
- Roles
- Disabled
Nov 10 2022
Nov 9 2022
Here's what the glow looks like now
attempting to remove changes from un-rebased pull
copied what is done in native/chat/settings/color-selector-modal.react.js
Nov 2 2022
rule changed from number to string for readability
Nov 1 2022
Oct 30 2022
Landed changes.
Oct 27 2022
- Updating D5483: added tests to check spoiler regex extracted values #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Oct 25 2022
Oct 20 2022
So I was basically wondering if we can test whether the RegEx matches what we are actually looking for. So for example, if we are doing something like expect(||hello||).toMatch(spoilerRegex), is there a way to test whether the RegEx is extracting out the "spoiler text", in this case hello?
Amended changes to the original diff.
Addressed Rohan's feedback
Hi @rohan, thank you for your review. To follow up on your points:
1: I've changed the it statements to be more descriptive.
2/3: I'm a bit confused on what you mean by "to actually test the match so we can see if we are matching what is expected" - could you please clarify?
4: I was getting a eslint/prettier problem when I tried to include the actual RegEx in the it statement, so I moved it to a comment. Is this okay?